242317 - Day and weekday titles in calendar view scroll away [weekview]

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Harry Boldt]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

When srolling down vertically in the calendar view, the line that shows the days
and weekdays disapears. As it is a title, this line should always be visible. 

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Wm]

(In reply to comment #0)

> When srolling down vertically in the calendar view, the line that shows
> the days and weekdays disapears. As it is a title, this line should always
> be visible. 

I think this "bug" is still UNCONFIRMED because no-one is sure what the reporter
means as he provided insufficient detail and no means to reproduce it.

If he means that scroll bars appear if events are outside the Preferences / Week
and Day views etc. then there is no bug.

Suggest mark as INVALID unless more detail provided soon.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

No, the reported has a point. The day names should not scroll away when
scrolling down.

Comment 3

[Harry Boldt]

Even the title (summary) of this bug report is clear and detailed enough! Scroll
down in the calender view, then tell me which column specifies friday. You will
have to count or to scroll up.

If you like this... 

Comment 4

[Wm]

How odd.  Which "calendar view" are Michiel and Harry seeing this in?  Because
it isn't happening to me and I believe it is happening to you.

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
+ 2004080916-cal

I wonder if it is a theme issue?

Comment 5

[gekacheka]

Attachment: day of week scrolls, leaving more space for hours

Comment 6

[gekacheka]

Attachment: day-of-week doesn't scroll, leaving space for ~2.5 less hours

A quick change to move the day-of-week and all-day elements into a new grid
outside the previous grid reduces the space available to show hours, so ~2.5
hours less can be shown.   Maybe this can be reduced if week-view is
redesigned.
(Also, the grid isn't the full width, so the days don't line up.)

Comment 7

[gekacheka]

Attachment: weekview.xul patch: move day-of-week and allday to new header grid (broken, do not check in)

This patch is a start.	Since the result takes so much space away from hours,
it is not clear to me that the result is better.  I think week view will need
to be redesigned so the day-of-week takes less height before this will be ok.

The patch is incomplete, and resulting week view is broken 
 1. day-of-week misaligned (need to make header grid full width like content
grid)
 2. work-week-only doesn't work (need to collapse/hide header columns like
content columns)

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

I don't see why makeing the header not scroll takes 2.5 hours. When there is no
scroll, the view should look the same. When you do ahve to scroll, you indeed
see a few hours less, but in return you see which day you are looking at. I
think the win is greater then the loss.

To make the grid line up, you need to 'rotate' the grid. So instead of defining
the cells in <columns/> you need to do it in <rows/>. Then look at
http://lxr.mozilla.org/seamonkey/source/layout/xul/base/src/grid/examples/scrollingrows.xul

Comment 9

[Harry Boldt]

The argument to win vertical space seams strange to me. A wrong placed date can
be much more unpleasant than the case to have less space. 

As a solution, I propose to froze the dayname-row in the weekview as an allways
visible header and then to allocate less vertical space for this header. I
think, there's really no reason to lose 45 px for a simple day caption.

Regards, Harry

Comment 10

[gekacheka]

Attachment: weekView.xul patch using nested rows technique (broken, do not check in)

The <rows> nested within <rows> technique would certainly make the change
simpler.
However, it isn't working for weekview, maybe in part because of boxes for
events.

It should not be necessary to 'transpose' the tree representation of the array.

It can put the cells in the right place either way.

The patch removes the overflow: auto from the content box around the grid, and
puts overflow: auto on the nested rows, so it does put the scroll bar on the
right box.  

However, moving the scrollbar does not scroll the rows.

Another problem I noticed is that if there is a box for an event showing, then
the box with the scrollbar will not shrink over the event.  If I resize bottom
of the window upward, the box with the scrollbar will shrink until it reaches
the bottom of the event, but no further.  After that, the bottom of the
scrollbar becomes invisible, indicating its box is no longer shrinking inside
the window.

Comment 11

[Michiel van Leeuwen (email: mvl+moz@)]

I think the cells don't scroll because you didn't transpose the grid. In the
example, the nested rows contain the cells. In your patch, they are empty.

The event boxes might not scroll, because they are not actually part of the
grid, but part of a stak above it. It so, then this makes it hard to fix this
way. But let's first test the transpose thing.

Comment 12

[gekacheka]

Attachment: weekview.xul, js, css patch: move day-of-week and allday to new header grid

Fixes bugs in previous patch with separate header grid approach.
(nested <rows> won't work with <stack> for event boxes as designed.)

weekview.xul:
  add header grid, move day-of-week and allday cells to this grid

weekview.js
  collapse/show day-off columns of header grid as well as content grid

skin/classic/calendar.css
skin/modern/calendar.css
sunbird/themes/winstripe/calendar.css
  add header grid ('week-view-header-holder') to content grid css
  remove padding outside grids: makes outside grid borders look worse when
scrollbar appears.  (Keep grid borders, probably better for printing.  Kept a
comment for padding that omits padding between header grid and content grid, to
show how it could be done.)

tested on Moz1.7.3, Sunbird 0.2a (1.8a4)

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

I tried your patch. (it didn't apply cleanly though. dunno what's up)

The split grid makes the header and the grid not line up anymore, if there is a
scrollbar. This is because the scrollbar takes space, and so there is less space
for the columns, and they will get a bit smaller. But this isn't really
noticable, because the header doesn't have gridlines, so all you see is the
alignment of the text move a bit.

When the window is small enough, a horizontal scrollbar will appear. But when
making the window even smaller, the vertical bar disappears, because the header
doesn't shrink anymore, and also doesn't scroll.

(this is no fun xul anymore....)

Comment 14

[gekacheka]

Attachment: weekview.xul, js, css patch: move day-of-week and allday to new header grid (same, recreated)

Same patch, recreated, maybe it will apply better.

The min-width issue (forcing v-scrollbar and throbber off right of window)
seems to occur on all the views (including multi-week view which has no title),
so may be beyond the scope of this bug.

Comment 15

[Wm]

I am still wondering if this isn't theme specific as I get scroll bars on both
the x and y no matter how much resizing I do (unless I make it too small to be
sensible, of course).

I am using the default FF theme (2.0 Gerich and Horlander)

maybe it would help if other people would try the default and see if the problem
still exists or say what themes they are using.

Comment 16

[Mostafa Hosseini]

Comment on attachment 159757 [details] [diff] [review]
weekview.xul, js, css patch: move day-of-week and allday to new header grid (same, recreated)

First note:
css doesn't like // commenting /* */ is preferred.

Comment 17

[Mostafa Hosseini]

Comment on attachment 159757 [details] [diff] [review]
weekview.xul, js, css patch: move day-of-week and allday to new header grid (same, recreated)

Other than that, looks great.
Checked in. Thanks

Comment 18

[Mostafa Hosseini]

Fixed in CVS.

Comment 19

[gekacheka]

Note: The above patch 159757 breaks horizontal scrolling of ALL views (not just
weekview) when window is narrower than 675 pixels with no sidebar, or 820 pixels
with sidebar.  (my comment #14 was wrong, it *is* caused by this patch.)
Calendar becomes not so useable on 640x480 or 800x600 screens, or in small
window on larger screens.   

Problem is we want the header grid and the hours grid to be able to overflow
horizontally and scroll together, but not overflow vertically so the hours box
will use its own vertical scroll bar.  Seems to need overflow settings for just
one dimension, which css can't do.

(Giving the whole week-view-box an overflow doesn't work: when the whole view
scrolls, the hours box no longer scrolls, so it loses the feature that the
day-of-week headers stay in view.)

One half-fix is to give week-view-header-box overflow: auto in parallel with
week-view-content box, so it can overflow.  This will at least allow the views
other than weekview to behave correctly in narrow windows.  This is only a
half-fix: in narrow windows, week view becomes ugly because the header grid has
its own independent scrollbar (that also partially obscures it).

 #week-view-header-box{
+   overflow             : auto;
 }
 

Comment 20

[Justin Wood (:Callek)]

Two words, |overflow-x| and |overflow-y| (css can do it).

I will elaborate more on another day, we may need -moz- prefix for those though,
not sure.

Comment 21

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: separate overflow-x and y

This patch separates overflow-x and -y. This way, it looks less bad. When
making the window small, at least the rest of the view is ok.
Only problem is that you don't see the vertical scrollbar, unless you use the
horizontal bar to scroll to the right. The vertical bar belongs to a box that
is child of the box the horizontally scrolls.

The patch is -w. I have a full patch that fixes indenting, but it is quite
long, so i'm not attaching that until the -w got review.

Comment 22

[gekacheka]

Comment on attachment 165890 [details] [diff] [review]
separate overflow-x and y

On TB0.9, I'm not seeing a difference.	The horizontal scroll bar still cannot
be used because the right side goes off the right side of the window.  Is this
what you see?

On Moz1.7.3, this patch eliminates the scrollbars, I guess overflow-x and
overflow-y aren't implemented on Moz1.7.3.

Comment 23

[Michiel van Leeuwen (email: mvl+moz@)]

It might need a recent trunk build, overflow-x is relativly new. maybe it in the
aviary branch.
The most important difference is that the tree view with events and (for
week/month view) the navigation buttons don't move out of view anymore. They can
get smaller now.

Comment 24

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: screenshot showing effect of last patch

Comment 25

[gekacheka]

Looks promising, but it did not work as in the image even on TB0.9.  The
throbber icon, right side of the events table, and the horizontal scrollbar were
all clipped off the right side of the window.

So since this patch makes things worse on Moz1.7.3, I think it may be best not
to check it in until after Moz1.8 is the stable release.  

(There is at least one other patch waiting for Moz1.8, maybe a status whiteboard
keyword would help find them, such as "requires1.8" .)

Comment 26

[Michiel van Leeuwen (email: mvl+moz@)]

I will try a patch with css like this

#week-view-content-box
{
   overflow             : auto;
   overflow-x           : hidden;
   overflow-y           : auto;
   ...
}

I hope it will work like it does now on 1.7, and like the screenshot on 1.8

Comment 27

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: try to stay 1.7 compatible

this patch should make the situation in 1.7 not any worse, but improve 1.8.
(not perfect yet, but an improvement)
gekacheka, can you test it in 1.7? thanks. (i don't have 1.7 builds)

Comment 28

[gekacheka]

Ok.  It turns out TB0.9 and Moz1.7.3 behave the same, the difference I noted
above was due to a testing error.

The new patch does not break either TB0.9 or Moz1.7.3, they both behave as
before (vertical scrollbar appears for content grid, horizontal scrollbar
appears at bottom, and does not shrink past left edge of vertical scrollbar).

Comment 29

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 165915 [details] [diff] [review]
try to stay 1.7 compatible

requesting review.
like i said, it doesn't fix the bug for every case, but at least makes it less
worse from some cases.

Comment 30

[gekacheka]

Comment on attachment 165915 [details] [diff] [review]
try to stay 1.7 compatible

week-view-holder is a weak name.  I'd change it to something that is more
suggestive of its purpose, maybe "week-view-hscroll-box".

Also, need to patch all four versions of calendar.css (classic, modern,
winstripe, pinstripe).

Otherwise looks ok to me.

Comment 31

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: full patch (checked in)

Comment 32

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 166010 [details] [diff] [review]
full patch (checked in)

Patch checked in. Leaving bug open for possible 1.7 work.

Comment 33

[Joey Minta]

*** Bug 259231 has been marked as a duplicate of this bug. ***

Comment 34

[Joey Minta]

fixed by the switch to the new views (bug 297934)

Comment 35

[gekacheka]

(In reply to comment #34)
> fixed by the switch to the new views (bug 297934)
> 

Actually, regressed by new views, where day labels and hours rows all scroll together again instead of separately.
But code is different from Sunbird 0.2 views, so separate bug 322979.