322979 - views should not scroll the labelling columns along the non-scrolling axis

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

If one scrolls the multiday-view vertically, after a bit of scrolling, the key which displays the day names is out of view.  A similar thing happens to the key which displays the hours when scrolling horizontally.  

Fixing this is likely to change our use of boxes in a non-trivial way, so it may want to happen at the same time we win mvl's WarOnBoxes <http://wiki.mozilla.org/User:Mvl/warOnBoxes>.  Additionally, we'll likely either have to refactor either the scrolling implementation and/or how the decoration works.

Comment 1

[Calum Mackay]

*** Bug 324407 has been marked as a duplicate of this bug. ***

Comment 2

[gekacheka]

For reference, Bug 242317 implemented this for the Sunbird 0.2 views.

Comment 3

[Stefan Sitter [:ssitter]]

*** Bug 327436 has been marked as a duplicate of this bug. ***

Comment 4

[Reed Loden [:reed]]

The bugspam monkeys have struck again. They are currently chewing on default assignees for Calendar. Be afraid for your sanity!

Comment 5

[ovidiu]

I think some issues generated by this are already resolved, as in comment #2, for day and week view. I would like to draw your attention on another situation that I think is related to this in month/multiweek view. 

First, I was looking for file a bog as below, but it may be dupe for this one IMO. It may also fit better in bug 312830 as I commented there, or maybe better to file it separated so that can be dependent on 312830 (which is not the case here). Please indicate as appropriate 

*Day box scroll in month/multiweek view should not scroll day label*

This is a minor issue, but I think the scroll in day box is unnatural and unexpected. This may fall dependent on other dom elements structure changes that may happen for more serious reasons.

I think this bug affects the structure of elements (box) used for representation of the day/events in month and multiweek view. I am not able to write a patch for it, I tried some css tweaks with no result, but I can show where I think the fault is.

*Today* [ltn 0.8] the elements in the month grid for a day are :

+calendar-decorated-month-view (id: month view)[same for multiweek]
 ......
  + xul:calendar-month-day-box
    + xul:vbox[flex="1"]                 ->I think this one is where the scroll appears
 --------------------------------------
|     - xul:label[anonid="day-label"]  | ->label is included in the scrolling area!
      + xul:vbox 
        + calendar-month-day-box-item
           .....etc (calendar event elements and details)

and look like:
+-----------------+
| *6*         [^] |  \
|  ---------  | | |   .
| | event 1 | | | |   .
|  ---------  | | |   .
|  ---------  |-| |   .
| | event 2 | |-| |    > all this is scrolling!
|  ---------  |-| |   .
|  ---------  | | |   .
| | event 3 | | | |   .
|  ---------  [v] |  /
+-----------------+

so that scroll includes day label, which I consider NOT correct

*It should be:*

 ......
  + xul:calendar-month-day-box
    + xul:vbox                           ->no scroll at this level
. . . . . . . . . . . . . . . . . . . .
      - xul:label[anonid="day-label"]    ->label NOT included in the scrolling area!
 --------------------------------------
|     + xul:vbox[flex="1"]             | ->this is what we need to scroll!
         + calendar-month-day-box-item
           .....etc (calendar event elements and details)

and look like:
+-----------------+
| *6*             |     ->no scroll at this level
|  ---------  [^] |  \
| | event 1 | | | |   .
|  ---------  | | |   .
|  ---------  |-| |   .
| | event 2 | |-| |    > only this should be scrolling!
|  ---------  |-| |   .
|  ---------  | | |   .
| | event 3 | | | |   .
|  ---------  [v] |  /
+-----------------+

so that the scrolling would NOT include day label

Is this only about moving the flex1 from the day box first child to the next level, where is the box that contains the events ? Or am I getting it all wrong?

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix v1

This patch fixes and also corrects scrolling a bit. If the mouse is scrolled on an overflowing month box, then the box itself is scrolled, otherwise the view is scrolled as before.

Comment 7

[ovidiu]

Does this solve also bug 391281?

Comment 8

[Berend Cornelius]

Comment on attachment 319745 [details] [diff] [review]
Fix v1

Your patch works fine and looks good, but I am wondering if it would not be better to make an own binding out of the box "day-items" with the mousescrollhandler within it. By this you would keep the logic inside where it belongs to without a need to query the event target and its content. The handler would be reduced to a one-liner ("event.stopPropagation();"
as far as I see.

Comment 9

[Berend Cornelius]

Comment on attachment 319745 [details] [diff] [review]
Fix v1

r=berend based on my previous comment.

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Yes, fixes bug 391281. I was looking for that one.

Berend, I think creating a binding for that is overhaul. It would be a very small binding and I don't see where this could be reused. Therefore it will only increase overhead.

Comment 11

[Philipp Kewisch [:Fallen][📱📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 12

[Berend Cornelius]

Philipp, I forgot to mention there is still a debugger statement within your code

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

Thanks for catching that, extra debugger statement removed and updated file checked in.

Comment 14

[ovidiu]

FWIW, I commented this fixing (for both bugs..) in bug 312830 that has a relation to these IMO (for the sake of tracking ..)

Comment 15

[Stefan Sitter [:ssitter]]

This checkin regressed Bug 432701.

Comment 16

[Andreas Treumann]

Checked in lightning 2008082103 and sunbird 20080820 -> VERIFIED