Help menu should conform to Apple Human Interface Guidelines

RESOLVED FIXED in Thunderbird0.7

Status

Thunderbird
Mail Window Front End
--
minor
RESOLVED FIXED
14 years ago
11 years ago

People

(Reporter: Brion Vibber, Assigned: Scott MacGregor)

Tracking

unspecified
Thunderbird0.7
PowerPC
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-aviary1.0)

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040505
Build Identifier: version 0.6 (20040502)

To conform with platform interface standards on Mac OS X, the help menu should
be slightly rearranged:

The main item, "Mozilla Thunderbird Help" should come first (before "Release
Notes") and have Cmd+? as the shortcut key.

"About Mozilla Thunderbird" should be removed, as it's already in the standard
location in the application menu.

Reproducible: Always
Steps to Reproduce:
1. Hit Cmd+?
2. Look at help menu
Actual Results:  
Nothing at all happens on Cmd+?; help menu is misordered.

Expected Results:  
Should launch help page on Cmd+?; help menu should be orderly with standard
shortcuts and appearance.

Apple Human Interface Guidelines:
http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGMenus/chapter_15_section_4.html#//apple_ref/doc/uid/TP30000356/TPXREF108
(Assignee)

Comment 1

14 years ago
cc'ing some OS X volunteers
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → Thunderbird0.8
(Assignee)

Updated

14 years ago
Target Milestone: Thunderbird0.8 → Thunderbird0.7
(Assignee)

Comment 2

14 years ago
Created attachment 150504 [details] [diff] [review]
fix for the main mail window

Jon sent me this patch which fixes this for the main mail window.
(Assignee)

Comment 3

14 years ago
this patch has been checked into the branch and the trunk. Leaving open for
address book and mail compose window. 
Whiteboard: fixed-aviary1.0
(Assignee)

Comment 4

14 years ago
Created attachment 150537 [details] [diff] [review]
better fix without the regression

Here's a better way to fix this that doesn't involve pre-processing
messenger.dtd.

Also I had to put back the reference to about thunderbird in the help item
otherwise we don't get the help menu item in the application menu anymore.
Attachment #150504 - Attachment is obsolete: true

Comment 5

14 years ago
Created attachment 150579 [details] [diff] [review]
fix for addressbook and compose, hides About in help menu only

This patch was created against aviary.
(Assignee)

Comment 6

14 years ago
Created attachment 150585 [details] [diff] [review]
modified patch

I tweaked Jon's patch a little bit.

Also I didn't check in the OS X core changes as I don't know enough about that
portion of the Mac code to know if it's the right thing to do.
(Assignee)

Updated

14 years ago
Attachment #150579 - Attachment is obsolete: true
(Assignee)

Comment 7

14 years ago
fixed branch and trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

14 years ago
The Help menu still has the redundant "About Mozilla Thunderbird" as of version 0.7 (20040616).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 9

14 years ago
See bug 215893. I have a new pacth forthcoming that fixes this the right way. I
just need to do a debug session to make sure I don't leak anything.
QA Contact: front-end

Comment 10

11 years ago
The issue from comment 8 was fixed in bug 301241. Marking fixed again.
Status: REOPENED → RESOLVED
Last Resolved: 14 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.