242672 - Help menu should conform to Apple Human Interface Guidelines

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Brion Vibber]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040505
Build Identifier: version 0.6 (20040502)

To conform with platform interface standards on Mac OS X, the help menu should
be slightly rearranged:

The main item, "Mozilla Thunderbird Help" should come first (before "Release
Notes") and have Cmd+? as the shortcut key.

"About Mozilla Thunderbird" should be removed, as it's already in the standard
location in the application menu.

Reproducible: Always
Steps to Reproduce:
1. Hit Cmd+?
2. Look at help menu
Actual Results:  
Nothing at all happens on Cmd+?; help menu is misordered.

Expected Results:  
Should launch help page on Cmd+?; help menu should be orderly with standard
shortcuts and appearance.

Apple Human Interface Guidelines:
http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGMenus/chapter_15_section_4.html#//apple_ref/doc/uid/TP30000356/TPXREF108

Comment 1

[Scott MacGregor]

cc'ing some OS X volunteers

Comment 2

[Scott MacGregor]

Attachment: fix for the main mail window

Jon sent me this patch which fixes this for the main mail window.

Comment 3

[Scott MacGregor]

this patch has been checked into the branch and the trunk. Leaving open for
address book and mail compose window. 

Comment 4

[Scott MacGregor]

Attachment: better fix without the regression

Here's a better way to fix this that doesn't involve pre-processing
messenger.dtd.

Also I had to put back the reference to about thunderbird in the help item
otherwise we don't get the help menu item in the application menu anymore.

Comment 5

[Jon Baumgartner]

Attachment: fix for addressbook and compose, hides About in help menu only

This patch was created against aviary.

Comment 6

[Scott MacGregor]

Attachment: modified patch

I tweaked Jon's patch a little bit.

Also I didn't check in the OS X core changes as I don't know enough about that
portion of the Mac code to know if it's the right thing to do.

Comment 7

[Scott MacGregor]

fixed branch and trunk

Comment 8

[Brion Vibber]

The Help menu still has the redundant "About Mozilla Thunderbird" as of version 0.7 (20040616).

Comment 9

[Don Crandall]

See bug 215893. I have a new pacth forthcoming that fixes this the right way. I
just need to do a debug session to make sure I don't leak anything.

Comment 10

[Magnus Melin [:mkmelin]]

The issue from comment 8 was fixed in bug 301241. Marking fixed again.