242830 - default theme is badly named "Mozilla Firebird (default)"

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Sophia Poirier]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040506 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040506 Firefox/0.8.0+

The default theme (Pinstripe) is named "Mozilla Firebird (default)" in the
Themes section of Preferences.  Firebird doesn't exist anymore, so it should say
"Firefox".

Reproducible: Always
Steps to Reproduce:
look in Themes in Preferences
Actual Results:  
see the word "Firebird"

Expected Results:  
see the word "Firefox"

Comment 1

[Hiro]

Probably, if the following lines are changed, it will fix.
http://lxr.mozilla.org/mozilla/source/toolkit/skin/mac/info/contents.rdf#13

Comment 2

[Hiro]

Attachment: quick patch

Comment 3

[Jeff Walden [:Waldo]]

Attachment: More correct fix (also makes a change to Qute)

Here's a slightly better patch in that "Firefox" isn't hardcoded into the name
of the theme (it uses a DTD import of brand.dtd to access a product name
entity).  I also made this change to Qute, which also hardcodes Firefox into
the file.

Note: I don't know if DTD imports are allowed in skin contents.rdf files.  If
they aren't this patch is void and the previous one should be used instead. 
Can someone please test this in a build (as I'm affected by bug 239643)?

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 148077 [details] [diff] [review]
More correct fix (also makes a change to Qute)


(In reply to comment #3)
> Note: I don't know if DTD imports are allowed in skin contents.rdf files.

Manually applying the above patch to
classic.jar!skin/classic/global/contents.rdf on Windows worked okay, and the
Themes section of Options wasn't borked.  This suggests that DTD imports in
skin contents.rdf files is okay.

Given the above, I'm putting this up for review from Ben.

Comment 5

[Jeff Walden [:Waldo]]

Nominating as blocking1.0?...

This is a simple polish issue that seems simple to fix.  It's also got a
(untested in a build) patch.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Blocking .9 but this isn't the fix. The fix is in my extension changes. 

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 148077 [details] [diff] [review]
More correct fix (also makes a change to Qute)

removing request since the fix, as ben says, is in the extension manager :)

Comment 8

[Jeff Walden [:Waldo]]

Reassigning to Ben because the Windows counterpart to this file has already been
coded (and creating a Mac port should be simple):

http://lxr.mozilla.org/mozilla/source/browser/app/profile/extensions/%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D/install.rdf

I notice the program name is hard-coded into the file ("Firefox" instead of
&brandShortName; with a DTD import).  I don't know using an entity is valid for
the install.rdf file or not, but if it is using the entity is probably a better
course than hard-coding.  Just food for thought for Ben...

Comment 9

[Mike Connor [:mconnor]]

that's the theme name though :) it can certainly be hardcoded ;)

Comment 10

[Mike Roberto]

it is also ugly and Qute should be the default theme

Comment 11

[Steffen Wilberg]

Is this file still in use? It says chrome:displayName="Mozilla Firebird Default".
http://lxr.mozilla.org/aviarybranch/source/toolkit/themes/pinstripe/global/contents.rdf?raw=1
One of those stupid binary files btw.

Comment 12

[Robin Monks]

Has been fixed in newer versions of Firefox.  Mano, can you verify this?