Closed Bug 24405 Opened 25 years ago Closed 24 years ago

Text gets cut off

Categories

(Core :: Printing: Output, defect, P3)

Product:
Core
Component:
Printing: Output
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: shrir, Assigned: waqar)

References

(
URL
)

Details

(Keywords: dataloss, Whiteboard: [nsbeta2-][rtm-])

Attachments

(1 file)

Patch to change border-default value to 500
733 bytes, patch
Details | Diff | Splinter Review 
I used today's commercial build (2000011908) on Linux.
To recreate the problem, try the following steps:

1. Install and launch mozilla
2. go to the  "www.mozilla.org" site
3. Once the page loads, select the FILE|PRINT menu option.
4. Observe that the page prints with a big font and text gets cut off on the
   right side.
OS: Linux → All
Also seen on today's mac commercial build (2000011910). Windows
build(2000011908) prints this page fine.
Target Milestone: M14
*** Bug 24730 has been marked as a duplicate of this bug. ***
Have a fix.. as soon as tree opens
Status: NEW → ASSIGNED
Fixed on the Mac.
Syd.. can you replace the variable "mPixelScale" with "mCPixelScale" in the
file nsDeviceContextPS.cpp
mCPixelScale is defined in nsDeviceContext.h.
Delete the mPixelScale defined in nsDeviceContextPS.h.  This should fix the 
problem for Postscript output. I can do this while you are here if you want.
Assignee: dcone → syd
Status: ASSIGNED → NEW
*** Bug 25830 has been marked as a duplicate of this bug. ***
Changes have been applied. Back to dcone
Assignee: syd → dcone
Fixed.  The pixelscale was added to Linux printing.  Some of the page cutting 
off is due to a margin problem in another bug. (15522)
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Verified on Linux build(2000020308m14) and Mac build(2000020308m14). On mac, the 
text does not get cut off at all(gets cut off on linux). Marking verified.
Status: RESOLVED → VERIFIED
On linux just modify the margins a tad and the text will be ok.
Maybee our defaults should have a wider right margin.
Yes..I altered the right margin to 0.50 and it worked.I nitially the right 
margin is set to 0.0. Can we set it to .50 as default ?
Syd, can you set the default right margin to 0.5.
Thanks
The default right margin is still 0.00 onlinux. As a result, the page still gets 
cut off on right side unless I set the margin to 0.50 manually.
This will need to get reopened, and nominated for beta1 in the status whiteboard
if I am to possibly fix this.
Reopening as per syd's comment
Status: VERIFIED → REOPENED
Keywords: beta1
Resolution: FIXED → ---
This is for you Syd.
Assignee: dcone → syd
Status: REOPENED → NEW
Putting on PDT- radar for beta.  Unless fix in hand.  If fix in hand, rickg says 
go for it.  But any amount of work left, bag for beta1.
Keywords: relnote
Whiteboard: [PDT-]
Status: NEW → ASSIGNED
Summary: Page printing huge, text gets cut off → Text gets cut off
I see the default right margin set to .50 in today's commercial build on linux 
(2000022808m14). Text no longer appears cut.
OS: All → Linux
2000022808m15...is the correct build number.
???

I haven't checked this in yet. Could you try removing (or copying somewhere)
your prefs.js file and start again? Probably the 0.5 you are seeing is coming
from your having changed the default and committing the pref.
Syd, I hadn't deleted my registry. Sorry... It still appears as 0.00 after I 
created a new profile.
Moving Syd's non-IM bugs to M20
Target Milestone: M14 → M20
nominating beta2.Text gets cut off unless user manually sets the margin. Correct 
margin should be automatically set.
Keywords: beta1, relnote → nsbeta2
Putting on nsbeta2+ radar.  Will become minus on 6/15.  Reassigning to Pavlov.
Pav, per Clayton, could you work with dcone to see if we can get this fixed?
Whiteboard: [PDT-] → [nsbeta2+] 6/15
Youza, I will look at this 6/15. Easy fix, no reason to drop it.
Cleaning up statu whiteboard by marking beta2 minus (6/15 has passed)

Note to Elwell: This just means that Netscape engineers are too doomed with 
other tasks to get to this prior to beta2 (we have lots of more critical stuff 
that is sneeded).  If outsider contributors can fix the bug... we'd be pleased 
as heck to watch it happpen!
Whiteboard: [nsbeta2+] 6/15 → [nsbeta2-]
*** Bug 45980 has been marked as a duplicate of this bug. ***
Can you first add nsbeta3? If nsbeta3-, then add helpme or so.

It shouldn't be too difficult to change the default value from 0 for bottom and
right to 0.5 (in what unit it is measured anyhow).

Since it works to store this value across session, this should be a trival task.

Goto Line 109 ff. in file:

./chrome/packages/widget-toolkit/global/content/printdialog.js
and change 

var print_margin_top = 500;
var print_margin_left = 500;
var print_margin_bottom = 0;
var print_margin_right = 0;

the 0 into 500 in the last lines.
FIX, please review and apply.

--- ./chrome/packages/widget-toolkit/global/content/printdialog.js.old  Sun Sep
10 17:51:58 2000
+++ ./chrome/packages/widget-toolkit/global/content/printdialog.js      Sun Sep
10 17:52:12 2000
@@ -108,8 +108,8 @@
   var print_paper_size = 0;
   var print_margin_top = 500;
   var print_margin_left = 500;
-  var print_margin_bottom = 0;
-  var print_margin_right = 0;
+  var print_margin_bottom = 500;
+  var print_margin_right = 500;
   var print_command = default_command;
   var print_file = default_file;

Wrong path. Please use: ./xpfe/global/resources/content/unix/printdialog.js
instead (source path, the other was the path in the final product)
Add via cc the owner of this component and ask him for review of the attached
patch.
This looks good to me.  The user can always change the margins also.. so it does 
not hurt anything.  It has my OK..

a=ben. Sorry for the delay. 
It would be nice if this could be suggested as rtm (and would get ++). Also it
would be nice if this could be checked in into the trunk.
(I cannot change the keywords and I cannot check in.)

Why this should be RTM? Well the fix is low risk and would remove this entry in
the release notes (from Netscape6PR3):
"(Linux only) Text is cut off on the right when printed. In the File menu,
choose Page Setup and change the rigth margin to .50 inches. Then try again."

Brendan, here seems to be a reviewed and approved "zero-risk" patch ready for
checkin. Can you find someone with CVS access to do that? Thanks.
Keywords: patch, rtm
Sorry, I must have confused 10/8 with 8/10 when looking at the approval date...
Ben or syd, can you check this in (if you haven't already)?  Thanks.

/be
Reassigning to kevin for triage
Assignee: syd → kmcclusk
Status: ASSIGNED → NEW
Marking rtm-.  This problem is not serious enough to make the cut for the RTM
branch. However, we need to get it checked into the trunk.

Reassigning to Waqar. Waqar could you check this into the trunk? The patch has
been approved and reviewed.
Assignee: kmcclusk → waqar
Marking rtm-.
Whiteboard: [nsbeta2-] → [nsbeta2-][rtm-]
dataloss - bits of the page go missing. Nominating for mozilla0.6 - there's an
approved patch, so could this go in? Changing the margin is not an immediately
obvious solution.

As an enhancement, could mozilla warn when the margins are set so small that
parts of the page will go missing?
Keywords: dataloss, mozilla0.6
Fix checked in.
Status: NEW → RESOLVED
Closed: 25 years ago → 24 years ago
Resolution: --- → FIXED
prints ok now on linux trunk 1212. VERIFIED
URL: http://www.mozilla.org → http://www.news.com
Status: RESOLVED → VERIFIED
Keywords: mozilla0.6
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: