244238 - Reflow should batch view updates

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Basically, we should batch view updates around reflow command processing.  This
will have two primary benefits:

1)  Invalidates will get batched better by the viewmanager
2)  We won't have as much painting of absolute or fixed positioned elements
    during intermediate stages of reflow (the various bugs where things flicker
    briefly in some random corner, etc).

To do this right we have to fix viewmanager to propagate update batches to the
root viewmanager.  Roc, should that all just happen in one patch (since the
presshell part is all of two lines long), or should the viewmanager changes get
a separate bug?

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Should probably fix it in two stages (view manager first, of course) to make it
easier to catch regressions.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Makes sense.  Bug 244290 filed for the viewmanager part.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Fixed by patch in bug 262760.  Not sure why we thought this depended on bug 244290..

Comment 4

[David G King]

Re comment #3. Does that mean this bug is fixed?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Yes, this is fixed.  I tried to mark it so in comment 3.