Closed Bug 24435 Opened 20 years ago Closed 18 years ago

socket transport needs synchronous DNS failure for Open*Stream() methods.

Categories

(Core :: Networking, defect, P3)

x86
Windows NT
defect

Tracking

()

VERIFIED INVALID

People

(Reporter: jud, Assigned: gordon)

References

()

Details

(Whiteboard: [nsbeta2-]3 days)

Attachments

(1 file)

Currently there is no way for synchronous users (those who use
OpenInput|OutputStream() of the socket transport to receive DNS failure codes.

This causes ftp:// urls with unknown hosts to report no status.

I propose that the socket transport implementations of Open*Stream() block until
a host is found/not found. The idea of the user sucessfully getting a stream on
a socket that doesn't even exist is not good.
Blocks: 18007
Good call. You're right, we do need to block the streams until we get the dns
callback.
I'm working on a fix for this.
Assignee: rpotts → valeski
Target Milestone: M14
Status: NEW → ASSIGNED
I'm attatching a proposed patch. This patch adds two member vars to the socket 
transport. One is a flag indicating whether or not a lookup has completed, and 
the other is a nsresult reserved for the return value of Open*Stream(). 

Rick, I've also un-commented the code that adds the transport instance to the 
work Q for an OpenOutputStream() call. I may very well have been the one that 
suggested we pull this out, but I don't recall..??
Attached patch proposed fix.Splinter Review
Target Milestone: M14 → M15
linux is having problems with this patch. off to m16
Target Milestone: M15 → M16
Moving to M17 (also beta2).
Target Milestone: M16 → M17
Whiteboard: 3 days
Keywords: beta2
Keywords: nsbeta2
fix finally in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
backed out changes
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
why?
there was some intermittant loading problem w/ edit page and compose window and
apparently imap was having trouble.
fixed.
Status: REOPENED → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → FIXED
we're baaaack. I need to rework this patch considerably.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Putting on [nsbeta2+] radar for beta2 fix. 
Whiteboard: 3 days → [nsbeta2+]3 days
Per today's PDT Networking QA review, moving from [nsbeta2+] to [nsbeta2-]
Whiteboard: [nsbeta2+]3 days → [nsbeta2-]3 days
Blocks: 58948
Target Milestone: M17 → mozilla1.0
-> doug. I'm not sure this is even a bug anymore w/ the new api changes.
Assignee: valeski → dougt
Status: REOPENED → NEW
mass move, v2.
qa to me.
QA Contact: tever → benc
what is milestone "mozilla1.0" anyway?  Moving to future.
Target Milestone: mozilla1.0 → Future
gordon implemented the dns client in mozilla.  over to him
Assignee: dougt → gordon
Target Milestone: Future → ---
After talking to Darin, we've decided this bug is not applicable anymore. 
Marking INVALID.
Status: NEW → RESOLVED
Closed: 20 years ago18 years ago
Resolution: --- → INVALID
VERIFIED/invalid
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.