Closed Bug 244489 Opened 20 years ago Closed 20 years ago

Customize Sidebar dialog clipped in Modern

Categories

(SeaMonkey :: Sidebar, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dveditz, Assigned: dveditz)

Details

(Keywords: verified1.7)

Attachments

(1 file)

The Customize Sidebar dialog has the up/down and cancel buttons clipped on the
right side in the Modern skin.

Because the size of this dialog is persistant you need to clear old values out
of localstore.rdf before testing this. Real users will see this clipped dialog
if they switch to the Modern theme before opening the customize dialog for the
very first time.
Comment on attachment 149188 [details] [diff] [review]
remove hardcoded width

Removes hardcoded width so sizeToContent can do its thing. Originally added to
fix bug 37724. Leaving height or else dialog squashes down as in the testcase
to bug 37836 (which must've been band-aided, the underlying cause is still
there).
Attachment #149188 - Flags: superreview?(sspitzer)
Attachment #149188 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 149188 [details] [diff] [review]
remove hardcoded width

As to bug 37836, instead of trees that dialog now uses listboxes which are
defined in xul.css to have a default size of 200px. Or alternatively instead of
specifying an overall height you could have added rows="20" (say) to the trees.
Attachment #149188 - Flags: review?(neil.parkwaycc.co.uk) → review+
Comment on attachment 149188 [details] [diff] [review]
remove hardcoded width

sr=sspitzer
Attachment #149188 - Flags: superreview?(sspitzer) → superreview+
Attachment #149188 - Flags: approval1.7?
Comment on attachment 149188 [details] [diff] [review]
remove hardcoded width

a=chofmann for 1.7
Attachment #149188 - Flags: approval1.7? → approval1.7+
Assignee: sidebar → dveditz
checked into trunk and branch
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed1.7
Resolution: --- → FIXED
verified
Status: RESOLVED → VERIFIED
Keywords: fixed1.7verified1.7
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: