Closed Bug 244674 Opened 21 years ago Closed 20 years ago

Long subjects lead to scrambled Windowtitle, possible unchecked sprintf ?

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Platform:
x86
Windows 98
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 280522

People

(Reporter: ryuken, Assigned: mscott)

Details

Attachments

(1 file)

screen capture showing bug
50.67 KB, image/jpeg
Details
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040206 Firefox/0.8 Build Identifier: Thunderbird version 0.6 (20040502) If the subject of a mail is longer than a certain number of characters (see steps to reproduce), the windowtitle of the main mail window (<subject> - <folder> - Mozilla Thunderbird) when the mail is highlighted or the windowtitle of a separate window in which that mail is opened looks something like (<subject> - <folder> - Mozill<Strange characters not reproducible on my keyboard>). I guess the windowtitle is built (sprintf ?) into an unchecked buffer, which would be both a security risk and a risk to stability and consistency of the program. Reproducible: Always Steps to Reproduce: 1.mail yourself a mail with the subject 01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 2. Get the mail 3. Highlight it and look at the windowtitle (window should be resized so that the whole windowtitle can be seen, if abbr. with ...) Actual Results: When highlighted or opened in its own window, the window title (the text in the title bar of the window) shows garbled characters from a certain point (something like 118 characters if I count correctly). My guess is, the window title was to large for the buffer and later memory operations overwrote the string-delimiting \0. Just a guess though, don't know the code. Expected Results: At least truncated the string, not overwritting memory not meant for the window title, as most likely evidenced by the missing trailing \0 in the Windowtitle. Using walnut theme, but bug also occurs in the default scheme.
Platform: PC Operating system: Win98 Thunderbird build: version 0.7+ (20040727) Firefox build: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1 I could not reproduce this bug. Are you using a later version of TB and is it still present ? Can you provide steps to reproduce again ?
Bug is still present under TB 0.72. It is also still reproducible by simply sending oneself a mail with the aforementioned subject. Only difference under TB 0.72 seems to be, that when a message is simply highlighted in the main Window, the window title is no longer set to the subject. But double-click on the message and the bug shows. The bug is also present under Firefox as I recently discoverd (FF0.92). Reproduce with the following html: <html> <head> <title>0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789</title> </head> <body> No Text </body> </html>
Just rechecked under Win20000, the phenomen does not occur there, though reliably on Win98. So I guess it's a problem with long window titles under that OS generally and not one with Mozilla specifically. Probably not worth the bother checking specifically for Win98 and truncating the window title, as I am surely the last person on earth to use that still :-).
I'm seeing this on Win98SE with FF0.9.2. I'll see if I can attach a screen capture.....
Still seeing this in Firefox 1.0..... And also in TB0.9. Interestingly (maybe), if the window is small enough to truncate the title, this bug is *not* apparent. But enlarging the window so the full title shows it's still present. Also, the length of title needed for this bug to show itself seems to be either variable, or to be different for FF and TB. I followed the reporter's steps to reproduce in TB, except that my email subject was: test 01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 The mail window's title is: "test 01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 - Mozilla Th" followed by 2 characters not on my keyboard. This is noticeably longer than the image I attached for FF in August. One other issue: the title of this bug ought (IMO) to be altered so "window" and "title" are separated.
Status: UNCONFIRMED → NEW
Ever confirmed: true
This should be fixed with patch of nsSendMessage() from bug 280522, comment 2.
marking dup, thx. *** This bug has been marked as a duplicate of 280522 ***
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: