Closed Bug 244826 Opened 21 years ago Closed 21 years ago

Find dialog should look native on all platforms

Categories

(Firefox :: Shell Integration, defect, P2)

Product:
Firefox
Component:
Shell Integration
Type:
defect

Tracking

()

Status:
VERIFIED INVALID
Milestone:
Firefox1.0beta

People

(Reporter: manfred, Assigned: bugzilla)

References

Details

User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040517 Camino/0.8b Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040517 Camino/0.8b The Cancel button of the "Find in This Page" dialog just closes the dialog; it cancels nothing. Therefore this dialog should have a close window widget instead and no Cancel button. Reproducible: Always Steps to Reproduce: 1. Edit->Find in This Page Actual Results: Find dialog has no close window widget. Expected Results: Find dialog should have a close window widget. Cancel butto is then unnecessary.
Cancel means that you do not want to search anything, that you changed your mind, makes perfect sense to me.
The "Find in This Page" is a modeless window and as such it needs a close window widget. Windows are *closed* not *canceled*.
(In reply to comment #1) > Cancel means that you do not want to search anything, that you changed your > mind, makes perfect sense to me. Keep in mind that MacOS X has different UI guidelines than Windows and Linux. Some things are just implemented differently as a matter of convention.
This really is how Mac OS X apps behave. Mac OS X apps that support the notion of search tend to have Previous and Next search buttons... no cancel button... the only way to dismiss the search dialog is to close the window via the (x) widget. Confirming this with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a2) Gecko/20040525 Firefox/0.8.0+ I also belive this exist in the Suite as well...
Ah it does... duping to bug 162257 Of course if you disagree... reopen. *** This bug has been marked as a duplicate of 162257 ***
Status: UNCONFIRMED → RESOLVED
Closed: 21 years ago
Resolution: --- → DUPLICATE
All right, I reopen this under the assumption that even if and when this is fixed in Mozilla, then Firefox will not automatically inherit the change. So this are mere sister-bugs but not duplicates.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Yes, the mozilla suites find dialog is totally different.
This is a change we also need to make for Find under GNOME. -> me
Assignee: firefox → mconnor
Status: UNCONFIRMED → NEW
Component: General → OS Integration
Ever confirmed: true
OS: MacOS X → All
Hardware: Macintosh → All
Target Milestone: --- → Firefox1.0beta
Example from Apple HIG http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/art/finddialog.gif we'll just have the two checkboxes and the find previous/find next buttons And GNOME will look different, of course. /me grumbles about silly HIG subjectiveness
Status: NEW → ASSIGNED
Flags: blocking1.0+
Priority: -- → P2
Summary: Find dialog should have close window widget (no Cancel button) → Find dialog should look native on all platforms
*** Bug 244827 has been marked as a duplicate of this bug. ***
Blake has been working in this area.
Assignee: mconnor → firefox
Status: ASSIGNED → NEW
Flags: blocking-aviary1.0RC1+
No longer valid w/ Find Toolbar.
Status: NEW → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → INVALID
v inv.
Status: RESOLVED → VERIFIED
Flags: blocking-aviary1.0PR+
Flags: blocking-aviary1.0+
You need to log in before you can comment on or make changes to this bug.