Closed
Bug 245077
Opened 20 years ago
Closed 20 years ago
"Find a specific bug" should be the default search page.
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: justdave, Assigned: glob)
References
Details
Attachments
(1 file, 4 obsolete files)
3.04 KB,
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
When a new Bugzilla user first visits Bugzilla's query page, they should be presented with the "Find a specific bug" panel by default, and require an extra click to get to the "Advanced Search" page. Of course, we all know there will be developers who complain because of the extra click to get to the advanced search, so I propose to set a cookie to store which panel they last visited, and in the absense of a format= parameter in the URL, we use the cookie to pick the format. This probably means renaming the existing query template to have a format name of "advanced" and setting the format internally when there isn't one given instead of relying on a default template to exist.
Reporter | ||
Updated•20 years ago
|
Flags: blocking2.18+
Target Milestone: --- → Bugzilla 2.18
- make search-specific default tab - switch order of search tabs - renamed __DEFAULT__ to advanced - added cookie DEFAULTFORMAT - renames search.html.tmpl to search-advanced.html.tmpl
Attachment #150943 -
Flags: review?
Comment 2•20 years ago
|
||
This would be a good time to make the default template configurable so we don't have to rename files (with its concomitant CVS difficulties) every time we change the default for a given CGI.
(In reply to comment #2) > This would be a good time to make the default template configurable so we don't > have to rename files (with its concomitant CVS difficulties) every time we > change the default for a given CGI. with this patch, changing the default template will not require a file rename, however the default is hardcoded in query.cgi .. $::FORM{'format'} = 'specific' are you proposing making 'specific' a parameter? i think that would be a bit of an overkill.
Comment 4•20 years ago
|
||
> are you proposing making 'specific' a parameter?
> i think that would be a bit of an overkill.
Sorry, no, I didn't look at the patch closely enough. Hardcoding it is fine for
now.
Comment on attachment 150943 [details] [diff] [review] make "Find a Specific Bug" default clearing review request, i'll do a new patch that fixes a typo in a comment
Attachment #150943 -
Attachment is obsolete: true
Attachment #150943 -
Flags: review?
Attachment #151071 -
Flags: review?
Comment 8•20 years ago
|
||
From the release notes.... $::FORM{} and $::COOKIE{} are deprecated. Use the $cgi methods to access them.
Attachment #151071 -
Flags: review?
uses $cgi instead of $::FORM{} and $::COOKIE{}
Attachment #151071 -
Attachment is obsolete: true
Attachment #151840 -
Flags: review?(bugreport)
Reporter | ||
Comment 10•20 years ago
|
||
Comment on attachment 151840 [details] [diff] [review] make "Find a Specific Bug" default v3 > my $format = GetFormat("search/search", >- $::FORM{'query_format'} || $::FORM{'format'}, >- $::FORM{'ctype'}); >+ $vars->{'query_format'} || $vars->{'format'}, >+ $vars->{'ctype'}); We never stuck 'ctype' into $vars anywhere. Need to get this from $cgi->param instead. The rest of this looks good. search is just moving to search-advanced, and there's no actual changes in that file, correct? If so, we should move it on the back end of cvs instead of via the patch, for the final patch iteration.
Attachment #151840 -
Flags: review?(bugreport) → review-
Assignee | ||
Comment 11•20 years ago
|
||
> We never stuck 'ctype' into $vars anywhere oops *sheepish grin* > search is just moving to search-advanced, and > there's no actual changes in that file, correct? correct, it's just a file rename.
Attachment #151840 -
Attachment is obsolete: true
Attachment #151988 -
Flags: review?
Reporter | ||
Updated•20 years ago
|
Attachment #151988 -
Flags: review? → review+
Reporter | ||
Comment 12•20 years ago
|
||
Comment on attachment 151988 [details] [diff] [review] make "Find a Specific Bug" default v4 Errr... I'm gonna have to revoke that... just found a problem. Go to reports, and go to the link for Graphical Reports. Then click the link for Search in the footer and see what you get. We need to exclude the report-.* formats from having a cookie set, I think. :)
Attachment #151988 -
Flags: review+ → review-
Reporter | ||
Comment 13•20 years ago
|
||
FYI: cvs copy for search-advanced.html.tmpl has been done. Next revision of this patch won't need to add the new file. We'll just need to remember to cvs delete the old one when we check this in.
Assignee | ||
Comment 14•20 years ago
|
||
excludes the report-.* formats from having a cookie set
Attachment #151988 -
Attachment is obsolete: true
Attachment #152280 -
Flags: review?(justdave)
Reporter | ||
Updated•20 years ago
|
Attachment #152280 -
Flags: review?(justdave) → review+
Updated•20 years ago
|
Flags: approval?
Reporter | ||
Updated•20 years ago
|
Flags: approval? → approval+
Reporter | ||
Comment 15•20 years ago
|
||
Comment on attachment 152280 [details] [diff] [review] make "Find a Specific Bug" default v5 >+++ query.cgi 2004-07-04 20:51:20.188092800 +0800 >@@ -22,6 +22,7 @@ >@@ -395,16 +396,33 @@ The problem is here ^^^ The 33 should be a 32. With that change, it applies.
Reporter | ||
Comment 16•20 years ago
|
||
Checking in query.cgi; /cvsroot/mozilla/webtools/bugzilla/query.cgi,v <-- query.cgi new revision: 1.125; previous revision: 1.124 done Removing template/en/default/search/search.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search.html.tmpl,v <-- search.html.tmpl new revision: delete; previous revision: 1.18 done Checking in template/en/default/search/tabs.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/tabs.html.tmpl,v <-- tabs.html.tmpl new revision: 1.4; previous revision: 1.3 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 17•20 years ago
|
||
FYI, this regressed. The report cookies are apparently still being set in 2.18rc1 and on the tip.
Blocks: 250881
Updated•11 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•