250881 - After creating a series DEFAULT query format is to create a series

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect, P1)

Description

[Joel Peshkin]

After the preferred format cookie went in, the search page uses the format of
the last search page used... even if it was for a series.

Comment 1

[Joel Peshkin]

This is a regression from bug 245077.

Critical because search is rendered unusable unless you manually clear the cookie.

Comment 2

[Dave Miller [:justdave]]

I'd even call it a blocker.

I specifically rejected the first patch for the query page for exactly this
reason...

Comment 3

[:glob ✱]

Attachment: use whitelist instead of blacklist for format cookie

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 152896 [details] [diff] [review]
use whitelist instead of blacklist for format cookie

>+# Set cookie to current format as default, but only if the format
>+# one that we should remember.
>+my $format_qm = quotemeta($vars->{'format'});
>+if (grep /^$format_qm$/, qw(specific advanced)) {

variables in regexps are naughty. ;)

how about:

if (grep {$_ eq $vars->{'format'}} qw(specific advanced)) {

Then you don't need to mess with quotemeta or anything.

Comment 5

[:glob ✱]

Attachment: changed grep to follow dave's suggestion

Comment 6

[Joel Peshkin]

checked in on both branches

Comment 7

[:glob ✱]

*** Bug 251157 has been marked as a duplicate of this bug. ***