245088 - The 'Customize toolbar' window looks bad in recent nightlies and 0.9rc

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Marek Stępień [:marcoos, inactive]]

Build: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040529
Firefox/0.8.0+

A vertical toolbar is shown in the Customize window, which makes the buttons
unreadable. 

A screenshot follows.

Comment 1

[Marek Stępień [:marcoos, inactive]]

Attachment: Screenshot

Comment 2

[Marek Stępień [:marcoos, inactive]]

I can also reproduce this bug in the aviary branch build for Linux.

(Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040605 Firefox/0.8.0+)

Comment 3

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch for customizeToolbar.js

Changing kWindowWidth in customizeToolbar.js from 600 to 650 fixes the problem.
This patch does just this.

Comment 4

[Marek Stępień [:marcoos, inactive]]

In my opinion, this bug should be a blocker for 0.9.

Comment 5

[Andrew Smith]

See bug 171454 - very similar, but no necessarily a dupe? Both are caused by
setting an explicit pixel width instead of letting the window resize automatically.
	

Comment 6

[Marek Stępień [:marcoos, inactive]]

In comment 0 I wrote "vertical toolbar", I of course meant "vertical scrollbar". :)

Comment 7

[Erich 'Ricky' Iseli]

Attachment: Another Screenshot - even worse

After opening the customize dialog several times, I even had this terrible
window.

Comment 8

[Marek Stępień [:marcoos, inactive]]

*** Bug 246005 has been marked as a duplicate of this bug. ***

Comment 9

[Marek Stępień [:marcoos, inactive]]

I wonder why some people have it even more narrow than I do (attachment 149623 [details])...

Comment 10

[Erich 'Ricky' Iseli]

(In reply to comment #9)
> I wonder why some people have it even more narrow than I do (attachment 149623 [details])...

I posted the narrow one. Actually, I get it only sometimes, usually I get
something similar to what you posted. If you open the customize dialog via
context menu of a toolbar, apply (without do any changes), open it again, apply
(make this several times in a row) then you will notice how the height of the
dialog changes (first showing only 2 lines of icons, then 2.5 lines, then 3
lines), and suddenly, you get the messed up dialog like shown in attachment 150368 [details]

Comment 11

[Erich 'Ricky' Iseli]

severity major since it makes it unusable. keyword regression

Comment 12

[Wily Yuen]

This bug persisted in Firefox 0.9 final, using GTK2+XFT build here.

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

confirming. I see this bug in state from attchment 150368 with 0.9 final. No
matter in new profile or old.

Comment 14

[Zibi Braniecki [:zbraniecki][:gandalf]]

Also the funny thing is that everytime i'm opening this pseudo-window it opens
in another place, width and height. In result somethimes i can use it.

Comment 15

[Jakub Argasiñski]

I have seen a situation like in 'Screenshot' at my girlfriends PC. In most cases
it renders correctly for me, but sometimes I get the same thing as in 'Another
Screenshot'.

Comment 16

[Erich 'Ricky' Iseli]

I hope someone can fix this ugliness for 0.9.1. I can't imagine advocating for
this version of firefox otherwise, despite the very nice improvements.

Comment 17

[Jon Henry]

Did this regress relatively recently, or had people been seeing it for a long
time before this bug was opened? Also, so far this seems to be linux only...are
those seeing the bug running with non-standard settings that could be causing
the problem (big font, etc.)? Not that it shouldn't be fixed to work with such
settings, I'm just trying to figure out what might cause this.

Comment 18

[Adam D. Moss]

I've been seeing this 'forever' (i.e. since I first tried firebird, after it
changed its name from pheonix).

Comment 19

[Jon Henry]

If it's not new, then there's a good chance this is a dupe of bug 171454, or at
least a symptom of the same problem.

Comment 20

[Travis Chase]

*** Bug 255024 has been marked as a duplicate of this bug. ***

Comment 21

[Andrzej Jarmoniuk]

Attachment: narrow window

I have seen the problem with window being narrow long before 0.9.
It may have something to do with my machine being rather slow (a Duron 850)?

Comment 22

[Andrzej Jarmoniuk]

(In reply to comment #17)

> Did this regress relatively recently, or had people been seeing it for a long
> time before this bug was opened? Also, so far this seems to be linux only...are

Sorry for additional bugspam. I remember seing it on Windows as early as in,
say, 0.6.

Comment 23

[Andrzej Jarmoniuk]

There is a race condition in the onLoad() function where the window is being 
moved while it's not completely created. I put an alert() before the 
repositionDialog() invocation and the problem vanished. 
 
I could try fixing it myself somehow but I guess it shouldn't be that hard now 
(plus, it's 2:26 am here). If it can't be fixed easily, I suggest disabling 
the scroll effect (at least for the 1.0 release). 

Comment 24

[Andrzej Jarmoniuk]

I have fixed it in my Firefox (but it's not at all elegant) by applying a 200 ms
delay in the onLoad() method in

$FIREFOX/chrome/toolkit.jar!content/global/customizeToolbar.js

and it works, but it can't be fixed this way in the official FF.

The elegant solution would be to delay the repositioning of the window until
it's available. But I don't know how to do it.

Comment 25

[Andrzej Jarmoniuk]

Attachment: a patch

The onLoad() function is called BEFORE the window is completely created.
Therefore, if ma
y happen (although, it doesn't have to, there's a race condition) that the
repositionDial
og() function does not have any effect.

So, we could periodically (say, every 10 ms) check if the window has been
constructed (by
 checking if window.left is not undefined). If so, we can proceed with the
repositioning.

Comment 26

[Andrzej Jarmoniuk]

Attachment: patch, standards compliant (kudos, gandalf)

1. Sorry for bugspam.

2. The fix is, I would say, temporary, until the bug with onLoad() (being
called before the window is ready) is fixed.

Comment 27

[Andrzej Jarmoniuk]

Comment on attachment 159266 [details] [diff] [review]
patch, standards compliant (kudos, gandalf)

It still doesn't work as it should. Sometimes the bug occurs.

Comment 28

[Andrzej Jarmoniuk]

Simply moving the hidechrome attribute to the xul increases window creation 
speed lot. 

Comment 29

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: 245088-customize-toolbar-no-slideout-0.patch

This patch kills the slide out/in animation (which looks like ass on anything
but the fastest builds/systems), and also sets up the dialog content before
repositioning.	It also doesn't try to force the width and/or height -- this
means that we'll end up with a possibly large window, but at least all the
icons will be visible without scrolling.  Calling repositionDialog from a
0-timeout would ensure that the dialog is always the right size, but it also
causes a visual "jump" of the dialog as soon as its displayed

Comment 30

[Zibi Braniecki [:zbraniecki][:gandalf]]

Why this patch does not remove slideOpen and slideClose functions since they're
not used anymore?

Andrzej wrote that setting width via XUL <window> property fixes this problem. I
think it's a better solution.

Comment 31

[Andrzej Jarmoniuk]

No, it did not. I have noticed a few "narror windows" with the settings moved to
XUL as well. But it did help make them less occuring, yes.

Comment 32

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Remove slide-out, make the window not reposition badly near the bottom of the
screen, add mconnor's close keybindings.

Comment 33

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed br & trunk. 

Comment 34

[Stefan Pietschmann]

looks like it has been fixed on the branch, so could somebody please add the 
fixed-aviary1.0 keyword?
(i know this is trivial but it would be useful for querying the overall number
of remaining bugs)

Comment 35

[Simon Paquet [:sipaq]]

This may have caused bug 262256.

Comment 36

[Dennis Jacobfeuerborn]

I still get the scrollbar plus the window still "looks bad" because it has no
border whatsoever. Screenshot follows.

Comment 37

[Dennis Jacobfeuerborn]

Attachment: screenshot of cutomize window