245455 - Fix console.css error-[caret|dash].gif paths and remove unused files

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[Stephen Walker]

Comment 1

[Stephen Walker]

Attachment: Prepend console-

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 149910 [details] [diff] [review]
Prepend console-

r=me, assuming you also make the same change to
mozilla/toolkit/components/console/skin/mac/console.css

and bonus points if you fix that file to not be a binary file in CVS :)

Comment 3

[Steffen Wilberg]

The files have been moved to
mozilla/toolkit/themes/winstripe/global/console/console.css
mozilla/toolkit/themes/pinstripe/global/console/console.css
mozilla/toolkit/themes/qute/global/console/console.css

mozilla/toolkit/themes/winstripe/global/console.css (one directory up) is not in
use and should be deleted. I guess the the same is true for
/pinstripe/global/console.css and /qute/global/console.css.

Blocks bug 244691.

Comment 4

[Mike Connor [:mconnor]]

Steffen, can you attach an updated and complete patch so I can just check this
in?  I'm slowly working through my backlogged review queue and my trees are all
messy :(

Comment 5

[Steffen Wilberg]

I'll also remove a bunch of unused files -> adjusting summary.

Comment 6

[Steffen Wilberg]

Attachment: fix and cleanup

The fixes to the arrow issue is in the first two files,
mozilla/toolkit/themes/winstripe/global/console/console.css and
mozilla/toolkit/themes/pinstripe/global/console/console.css.
I've changed the latter file to unix style line endings before diffing. The
patch itself also has unix style lineendings, so it should really fix the issue
with this file consisting of one line only.
The respective qute file is already (still) correct.

I removed these files and their respective jar.mn entries since they're not in
use, see
http://lxr.mozilla.org/aviarybranch/search?string=global%2Fskin%2Fconsole.css:
mozilla/toolkit/themes/winstripe/global/console.css
mozilla/toolkit/themes/pinstripe/global/console.css
mozilla/toolkit/themes/qute/global/console.css.

The only file referencing them is
mozilla/extensions/inspector/resources/content/tests/allskin.xul. But that file
is not in use either. In fact, opening
chrome://inspector/content/tests/allskin.xul crashes Firefox.

The last two files are not in use either:
mozilla/toolkit/components/console/skin/Makefile.in
mozilla/toolkit/components/console/skin/jar.mn
This is a leftover of the "skin" directories removal.
They're unused because mozilla/toolkit/components/console/Makefile.in doesn't
have "DIRS = skin".

I've successfully built and tested Firefox from the aviary branch on Windows.

Comment 7

[Steffen Wilberg]

Attachment: fix and cleanup v1.1

One part of the previous patch doesn't belong here.

Comment 8

[Steffen Wilberg]

Comment on attachment 152459 [details] [diff] [review]
fix and cleanup v1.1

>Index: mozilla/toolkit/themes/pinstripe/global/console/console.css
>.console-row[type="warning"] {
>  list-style-image: url("chrome://global/skin/icons/alert-exclam.png");
>-  padding-right: 10px;
...
>#ButtonEval {
>  margin: 2px 2px 2px 0px !important;
>-  -moz-appearance: button-bevel;
I'm not removing these lines. Maybe there are stray unix or windows style line
endings...


>Index: mozilla/toolkit/themes/pinstripe/global/console.css
>-/*
...
>.console-row[type="warning"] {
>  list-style-image: url("chrome://global/skin/icons/alert-exclam.png");
>-  padding-right: 10px;
This file is to be removed completely, so don't care about this line.

Comment 9

[Steffen Wilberg]

Attachment: fix and cleanup, unbitrotten

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 152885 [details] [diff] [review]
fix and cleanup, unbitrotten

oops, wrong window.  r=me.

Comment 11

[Steffen Wilberg]

Fixed br & trunk.

Comment 12

[Steffen Wilberg]

Qute now fixed as well br & trunk. I assumed Mike's r+ is valid for that as
well, as it's the very same change.

Comment 13

[Uri Bernstein]

I'm pretty sure this fix is what caused bug 258652.

"alert-exclam.png" looks out of place when the other icons are gifs.