245497 - statusbar displayed wrong (not obeying gtk theme)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

I'm using the gtk theme smokey blue
(gtk 2.4, gnome 2.6)

mozilla shows a grey status bar, instead of a blueish one that other gtk apps show.
attaching a screenshot in a second.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: screenshot

at the top: gedit statusbar

at the bottom: mozilla statusbar

Comment 2

[Adam Guthrie]

*** Bug 322775 has been marked as a duplicate of this bug. ***

Comment 3

[Jonathan Haas]

This should be fixed because it makes Firefox look really bad on Linux.

Comment 4

[Teune van Steeg]

I almost have a patch ready, but I think this should really be a Core->Widget:GTK bug.

Comment 5

[Teune van Steeg]

Attachment: screenshot to wet your appetite

Screenshot of three windows (from top to bottom: Nautilus, Firefox trunk with upcoming patch, Firefox 2.0) and three different themes (from top to bottom: Clearlooks-Gull, Simple, Clearlooks).

Comment 6

[Teune van Steeg]

Attachment: patch

This patch makes the frame widgets representing the statusbar panels actual children of a statusbar widget, so they get styled correctly.

It also makes the background of the resizer grip to be styled corectly, by drawing a frame for the resizer grip.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Do we have resizers that aren't part of a status bar? I think we might. Would this break them?

Comment 8

[Teune van Steeg]

Attachment: patch v2

Actually, I didn't think of resizers at other places than the status bar, but the previous patch didn't break them.

But because a frame on a status bar is all the status bar resizer needs for a correct styling, I'll leave the status bar dependency for the resizer out of this patch, and let it just depend on a window (as originally).

Comment 9

[Reed Loden [:reed]]

Comment on attachment 288786 [details] [diff] [review]
patch v2

Small patch that lets the statusbar be natively themed on Linux.

Comment 10

[Mike Schroepfer]

Comment on attachment 288786 [details] [diff] [review]
patch v2

Great stuff!

Comment 11

[Reed Loden [:reed]]

Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.40; previous revision: 1.39
done
Checking in widget/src/gtk2/nsNativeThemeGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v  <--  nsNativeThemeGTK.cpp
new revision: 1.113; previous revision: 1.112
done

Comment 12

[Mathieu Pellerin]

Attachment: status bar still not matching gnome theme

noticed recently that the firefox status bar still does not fully match what's defined by the gtk theme. seems the margin in between status bar cells is ignored by the fox.

I'm using the murrine-clearlook theme.

should this bug be reopened?