246409 - NS_KEY_PRESS events should always have a keyCode

Status: RESOLVED DUPLICATE of bug 1479964

(Core :: DOM: Events, defect, P5)

Description

[Ilya Konstantinov]

Currently, we don't set the keyCode for keypress events which have a charCode. 
This was done to solve bug 13447, but no longer seems required (I reversed the 
fix, and Delete/Backspace keys work as usual). 
 
Solving this bug would improve also improve our IE compatibility. (Our 
proprietary KeyEvent object is modeled on IE's.)

Comment 1

[Ilya Konstantinov]

Attachment: Fix for gtk

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's also modeled off of
http://www.w3.org/TR/1999/WD-DOM-Level-2-19990923/events.html#Events-eventgroupings-keyevents
(which was removed in the next draft).

Comment 3

[Ilya Konstantinov]

Attachment: Testcase

Comment 4

[Ilya Konstantinov]

Attachment: Same patch, for gtk, gtk2, windows and mac

gtk and gtk2 patches were tested by me.
windows patch was tested by jst.
macos patch is a "blind patch"; a mac developer should test it.

Comment 5

[Johnny Stenback (:jst)]

Hmm, I can't believe I didn't notice this the first time I tested windows
version of this diff, but this change makes the '.' key not work as expected in
input fields. If you apply this diff, start Firefox and start typing in the URL
bar, no '.'s show up when you hit the '.' key. And if you position the cursor in
the middle of some existing text, hittin the '.' key acts as if you've hit the
'Del' key! Any thoughts?

Comment 6

[Ilya Konstantinov]

Also, this patch causes regression described by bug 250198 (on gtk2). I wonder 
why things are so sensitive to having keypresses without keyCode. 

Comment 7

[Johnny Stenback (:jst)]

*** Bug 270612 has been marked as a duplicate of this bug. ***

Comment 8

[Mats Palmgren (inactive)]

I think this might confuse existing scripts on some sites, so I'm leaning
towards INVALID/WONTFIX.  As mentioned in comment 2, DOM2 Events at one
point required both keyCode and charCode for all keyup/down/press events,
but the whole section on keyboard events were later removed.
http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-eventgroupings-keyevents

Looking at "DOM Level 3 Events Specification" there is no "keypress" event,
it seems to have been replaced by a "textInput" event and none of the events have keyCode/charCode, instead there is "keyIdentifier", "keyLocation"
http://www.w3.org/TR/DOM-Level-3-Events/events.html#Events-KeyboardEvent
and "data"
http://www.w3.org/TR/DOM-Level-3-Events/events.html#Events-TextEvents-Interfaces

I get the impression that WHATWG will not define its own keyboard events,
but instead refers to DOM3 Events.
http://www.whatwg.org/specs/web-apps/current-work/#events

Comment 9

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.