246447 - Alt/Control/Shift/Meta should generate KeyUp and KeyDown but not KeyPress

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Ilya Konstantinov]

Alt/Control/Shift/Meta should generate KeyUp and KeyDown events, but not 
KeyPress events. (KeyPress events are not supposed to be fired for all kinds of 
"system" keys.) 
 
Currently, the gtk implementation is a mess; KeyUp/KeyDown are not generated 
for any events, while KeyPress is generated only for Alt.

Comment 1

[Ilya Konstantinov]

Attachment: Patch

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 150588 [details] [diff] [review]
Patch

How about gtk2?  That's relaly what we need to be focusing on.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 150588 [details] [diff] [review]
Patch

sr=jst

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsGtkEventHandler.cpp;
/cvsroot/mozilla/widget/src/gtk/nsGtkEventHandler.cpp,v  <--  nsGtkEventHandler.cpp
new revision: 1.186; previous revision: 1.185
done


leaving open for now in case you want to address gtk2 in this bug.

Comment 5

[Ilya Konstantinov]

Attachment: Testcase

Use the testcase to verify Mozilla behaves as the bug description says.

Comment 6

[Ilya Konstantinov]

Attachment: Patch for gtk2

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 152186 [details] [diff] [review]
Patch for gtk2

sr=jst

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

gtk2 patch checked in
Checking in nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.111; previous revision: 1.110
done

please mark fixed if it is.
would this be a good thing for the 1.7 branch?

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

the gtk2 checkin caused bug 250198

-        event.keyCode = 0;
readding this line fixes that bug

Comment 10

[Ilya Konstantinov]

My patch for bug 246409 somehow crept into this patch. I appologize. Please 
return this line. I'll look further on how I can solve bug 246409 safely.