24733 - [dogfood][beta]browser turns pink

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P2)

Description

[german]

after having delat with bug 24662 and having changed the font dpi setting to no
avail, I restarted seamonkey to see whether that would have an effect. Now , I
kid you not, all displayed HTML pages as well as some browser and mail XUL
turned pink (see atchment). Only the HTML colors that were not set by the page
author were affected, in other words the HTML default colors. I believe this is
related to prefs becuase:
a) it did not seem to affect my other profiles
b) it happened after changing one pref (see bug 24662)
c) browser default colors is a pref.
Somehow prefs.js could have been whacked?

Comment 1

[german]

Attachment: screenshot

Comment 2

[german]

Now quickly scanning my prefs.js for that profile reveals:
[snip...]
user_pref("browser.anchor_color", "");
user_pref("browser.background_color", "");
user_pref("browser.bookmark_columns_win", "v1 3 1:4628 2:3705 4:1665 3:1999");
user_pref("browser.bookmark_window_rect", "74,23,626,516");
user_pref("browser.cache.check_doc_frequency", 1);
user_pref("browser.cache.disk_cache_size", 3000);
user_pref("browser.download.dir", "C:\\WINDOWS\\Desktop\\");
user_pref("browser.download_directory", "C:\\WINDOWS\\Desktop\\");
user_pref("browser.foreground_color", "");
[snip...]
Is that a problem?

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

aHA!

now I think I know what you're talking about. I may have a fix for this in my 
tree at the moment. let me run some quick tests on this and I'll get back to 
you...

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

hm... I cant seem to reproduce this. maybe its not what I thought.. I pasted the 
prefs you give into my prefs file and I dont experience this problem. can you 
attach your entire prefs file?

Comment 5

[german]

everytime i restart the base colors change now. I'll add two attachment s if you
need proof - first it turned yellow this morning, after having installed a new
fresh build 2000012408, after another restart it turned orange.

Comment 6

[german]

Attachment: screenshot after starting fresh build 2000012408 (yellow)

Comment 7

[german]

Attachment: ...and after restarting that new build again...(orange)

Comment 8

[german]

Attachment: what a web page (yahoo stocks) looks like with the default colors screwed up...

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

haha! it seems to be related to colour prefs. Lemme see if I can hack around 
this in the FE...

Comment 10

[Chris McAfee]

ben's on the case, m14.

Comment 11

[leger]

Putting on pdt- radar per pdt mtg today.  Not a blocker to daily use.

Comment 12

[leger]

Putting on pdt- radar per pdt mtg today.  Not a blocker to daily use.

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

okay I think I have a fix to prevent this from happening. it doesnt cure the 
random colour setting ability of colour prefs, it doesnt affect the fact that 
setting a bg/fg colour in prefs turns the CHROME that colour (I opened a 
separate bug on that last night). It does however prevent you from ever setting 
a colour pref to "" (& => avoid getting random weird colour selections). 

holding for tree reopening...

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

I have checked in a fix that should prevent this from happening, from the FE by 
preventing the PrefWindow from accidentally setting empty strings to colour 
prefs.

this does not stop you going and editing pref.js and putting in "" yourself, but 
that's a fringe case. 

Another bug has been opened on the chrome being affected by color changes in 
prefs. 

Comment 15

[sairuh (rarely reading bugmail)]

i no longer see this...

Comment 16

[german]

*** Bug 24919 has been marked as a duplicate of this bug. ***

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

*** Bug 27185 has been marked as a duplicate of this bug. ***

Comment 18

[leger]

Bulk move of all Pref UI component bugs to new Preferences component.  Pref UI 
component will be deleted.

Comment 19

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/650eb1b4290f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24733: Setup search for Unified Search experimentation
https://hg.mozilla.org/releases/mozilla-beta/rev/b4609d4e85ef
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24733: Create nimbus feature for Unified Search experimentation