Even though alot have been eliminated, a few instances of having boolean conditions in SQL statements exist. I have created a patch to convert these to equality tests instead for better database independence. For example: SendSQL(" SELECT DISTINCT groups.id, name, description, isactive FROM groups, user_group_map - WHERE user_id = $userid AND NOT isbless + WHERE user_id = $userid AND isbless = 0 AND user_group_map.group_id = groups.id - AND isbuggroup + AND isbuggroup = 1 ORDER BY description "); I am also making this report a blocker on the PostgresSQL support bug.
That's so simple and obviously correct, I think we should just ask for review on it right now and get it checked in. I'll bet bbaetz could do it; he's usually interested in things that block PgSQL. :-)
Comment on attachment 151391 [details] [diff] [review] Boolean conversion patch for better db independence r=joel
Attachment #151391 - Flags: review+
OS: Linux → All
Hardware: PC → All
Target Milestone: Bugzilla 2.20 → Bugzilla 2.18
dkl: are you checking this in? I could do it for you if you don't have the time, just let me know. Thanks!
Status: NEW → ASSIGNED
Sure. Be my guest. Been swamped here this week with updates. Also am not sure if I can checkin anymore yet since I have yet to send Myk my public key for CVS access. I need to get on that. Dave
Checking in buglist.cgi; /cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi new revision: 1.253; previous revision: 1.252 done Checking in editgroups.cgi; /cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v <-- editgroups.cgi new revision: 1.37; previous revision: 1.36 done Checking in request.cgi; /cvsroot/mozilla/webtools/bugzilla/request.cgi,v <-- request.cgi new revision: 1.13; previous revision: 1.12 done Checking in Bugzilla/Bug.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm new revision: 1.36; previous revision: 1.35 done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Oooops, missed one :-).
I can't reopen this one, so someone else please...
Thomas, -- open another bug. If re reopened this one, it would be impossible to tell whicj patch had approval, etc...
You need to log in before you can comment on or make changes to this bug.