Convert Bugzilla footer to html4 and css (addon for bug 245924)

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
User Interface
--
enhancement
RESOLVED FIXED
13 years ago
5 years ago

People

(Reporter: Svetlana Harisova, Assigned: Svetlana Harisova)

Tracking

unspecified
Bugzilla 2.18
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

13 years ago
In patch to bug 245924 we don't take into account that some users
will may want to style by css different group of links
in are different ways (e.g. actions-group will be green, 
edit-group will be yellow and saved-searches group will be
an other favorite color).

The our previous implementation of footer has made this impossible, 
because we assign ID not for all group=links+name_of_group but only for 
name_of_group:

<div class="group">
    <div id="link-edit">Edit:</div>
    <div class="links">
    ......
    </div>
</div>

The present CSS specification doesn't allow to access parent
properties from child rule.

We can assign ID for group=links+name_of_group, and when all
other users can design by CSS both whole group and
links or name_of_group with help of context selectors.

We have rewritten our previous patch from this point of view.
Now code looks like:

<div id="links-edit">
<div class="label">Edit:</div>
    <div class="links">
    ......
    </div>
</div>

Sorry for your inconvenience.
(Assignee)

Comment 1

13 years ago
Created attachment 151552 [details] [diff] [review]
Provides an ability to style different group of links in diffrent ways in footer
(Assignee)

Updated

13 years ago
Attachment #151552 - Flags: review?(myk)
Comment on attachment 151552 [details] [diff] [review]
Provides an ability to style different group of links in diffrent ways in footer

The change makes sense, but this patch causes the content of the useful links
box to get unnecessary extra top padding.  Strangely, you didn't change any
padding in this patch.	Perhaps the existing padding-top rule gets
misinterpreted for some reason?
Attachment #151552 - Flags: review?(myk) → review-
(Assignee)

Comment 3

13 years ago
Created attachment 152127 [details] [diff] [review]
Second attempt.

We have corrected code as far as could understand you.

If it is not difficult for you, next time specify browser and its version, in
which you observe one or another defect, please. It will help us very much.

If you have opportunity, the best variant is to give screenshot with defect.
Attachment #151552 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #152127 - Flags: review?(myk)
Comment on attachment 152127 [details] [diff] [review]
Second attempt.

Sorry, I should have known you'd need to know the browser. :-/

I tested in Mozilla Firefox 0.9 on Linux.  The new patch still changes
formatting on the same browser, but less so, and it still looks good. r=myk
Attachment #152127 - Flags: review?(myk) → review+
Minor low-risk update to previously checked in patch. a=myk and checking in for
contributor without CVS access:

Checking in css/global.css;
/cvsroot/mozilla/webtools/bugzilla/css/global.css,v  <--  global.css
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/global/useful-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v
 <--  useful-links.html.tmpl
new revision: 1.27; previous revision: 1.26
done
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Flags: approval+
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
Blocks: 253449
Assignee: myk → light
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.