Thunderbird biff integration refers to the old profile APIs

RESOLVED FIXED in Thunderbird0.8

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
14 years ago
a year ago

People

(Reporter: Scott MacGregor, Assigned: Benjamin Smedberg)

Tracking

unspecified
Thunderbird0.8
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

14 years ago
When starting up the app, nsMessengerWinIntegration trys to use the old profile
service in order to get the profile name:

http://lxr.mozilla.org/mozilla/source/mailnews/base/src/nsMessengerWinIntegration.cpp#458

We need to add a thunderbird ifdef to use the new APIs.

Patch coming up.
(Reporter)

Updated

14 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.8
(Reporter)

Comment 1

14 years ago
Created attachment 151728 [details] [diff] [review]
possible fix

This fix would work except for one problem :). The toolkit profile service is
not registered with the component manager in the normal startup case. Only when
we are doing the scopeXPCOM startup thing...

http://lxr.mozilla.org/mozilla/source/toolkit/xre/nsAppRunner.cpp#913

Benjamin, do you know why the profile service is unavailable for non startup
consumers? Is there another way for mailnews to get the name of the current
profile like we did with the old profile service API?
(Assignee)

Comment 2

14 years ago
There is no such thing as a current profile name, only a current profile path
(for instance, you can start the program with thunderbird -profile
/path/to/profile. Which is what I think you actually want to do here.

Hrm, I thought I already fixed this code, lemme look and see if I forgot to
check in a file or checked in something similar already.
(Reporter)

Comment 3

14 years ago
Benjamin, did you happen to find that code snippet you were looking for?
(Reporter)

Comment 4

13 years ago
Benjamin, did you happen to find that code snippet you were looking for from the
semi-single profile landing? I'd like to get this fixed for 0.8 if we can. Thanks!
(Assignee)

Comment 5

13 years ago
Created attachment 156591 [details] [diff] [review]
use -profile <path> instead of -p <name>

I couldn't find it, so I just re-created it.
Assignee: mscott → bsmedberg
Attachment #151728 - Attachment is obsolete: true
(Assignee)

Comment 6

13 years ago
Comment on attachment 156591 [details] [diff] [review]
use -profile <path> instead of -p <name>

Scott, my win32 machine is fried with a bad motherboard, so I can't test this
(or even build it).
Attachment #156591 - Flags: review?(mscott)
(Reporter)

Comment 7

13 years ago
Created attachment 156818 [details] [diff] [review]
some minor tweaks to make it work
(Reporter)

Updated

13 years ago
Attachment #156591 - Attachment is obsolete: true
(Reporter)

Updated

13 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Assignee)

Updated

13 years ago
Attachment #156591 - Flags: review?(mscott)
Depends on: 1309569
No longer depends on: 1309569
You need to log in before you can comment on or make changes to this bug.