248898 - strict javascript warnings

Status: RESOLVED FIXED

(Core Graveyard :: Profile: Roaming, defect)

Description

[Henrik Gemal]

Warning: anonymous function does not always return a value
Source File: chrome://sroaming/content/prefs/all.js
Line: 379, Column: 35
Source Code:
    return errorProp ? true : false;

Warning: reference to undefined property parent.roaming
Source File: chrome://sroaming/content/prefs/top.js
Line: 59

Warning: assignment to undeclared variable registry
Source File: chrome://sroaming/content/prefs/all.js
Line: 158

Warning: redeclaration of var checkbox
Source File: chrome://sroaming/content/prefs/files.js
Line: 138, Column: 10
Source Code:
      var checkbox = children[i2];

Comment 1

[Henrik Gemal]

Attachment: v1

Comment 2

[timeless]

Comment on attachment 151942 [details] [diff] [review]
v1

>-      registry = Components.classes["@mozilla.org/registry;1"]
>+      var registry = Components.classes["@mozilla.org/registry;1"]
>                            .createInstance(Components.interfaces.nsIRegistry);
fix up the indentation of the cI line.

>Index: files.xul
these changes don't look related

>-  if (!parent.roaming)
>+  if (typeof(parent.roaming) == "undefined")

personally i prefer !("roaming" in parent && parent.roaming).

--

Warning ``redeclaration of var checkbox'' [xs] in file
``chrome://sroaming/content/prefs/files.js'', line 138, character 10.
Error ``listitem has no properties'' [xs] in file
``chrome://sroaming/content/prefs/files.js'', line 104, character 0.
Exception ``TypeError: listitem has no properties'' thrown from function
SetFile(elementID=string:"filePassword", filename=string:"73427382.s") in
<chrome://sroaming/content/prefs/files.js> line 104.
[e] message = [string] "listitem has no properties"
Exception ``TypeError: listitem has no properties'' thrown from function
SetFiles() in <chrome://sroaming/content/prefs/files.js> line 84.
[e] message = [string] "listitem has no properties"

Comment 3

[Ben Bucksch (:BenB)]

Comment on attachment 151942 [details] [diff] [review]
v1

Sorry for my lack of response here. Most of this is being fixed in bug 249359
and bug 244558. Left is only (at most):

+	 <listitem type="checkbox"
+		   id="training"
+		   filename="training.dat"
+		   label="" />

-  if (!parent.roaming)
+  if (typeof(parent.roaming) == "undefined")

Comment 4

[Philip Chee]

Last bit fixed by the removal of roaming.