249419 - Changing identities does not place assigned signature in correct spot when replying

Status: RESOLVED DUPLICATE of bug 218346

(Thunderbird :: Message Compose Window, defect)

Description

[ccrawford]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)
Build Identifier: 

When replying to an email message and then switching identity the original 
identity's signature is not removed. If you then switch back to the original 
identity the signature is inserted again.

--> This occures when you have the option 'place my signature below my reply'. 

Any identity not the primary (account) identity will place the signature at 
the bottom of the reply rather than replacing the signature inserted above the 
quoted text.

Reproducible: Always
Steps to Reproduce:
1. Add an identity to your account
2. Add a different signature to that identity
3. Set the option 'place my signature below my reply'
4. Reply to an email (account sig shows correctly)
5. Change identity to new identity
6. Note that account sig stays and the new identity's sig is at the bottom of 
the email.
7. Switch back to the account identity.
8. Observe insertion of account's sig once again, creating two sigs.

Actual Results:  
non-primary identity's sig was misplaced at bottom of page and then removed 
when switched to primary identity. Primary identity's sig is never remove and 
is again placed into the message (but at the correct spot).

Expected Results:  
Non-primary identities should follow 'place my sig below my reply' option.

Comment 1

[ccrawford]

This is in version 0.7.1 (20040626) (Windows).

Comment 2

[X x]

This also happens when composing new mails, not just for replys.

1. Start new mail
2. See sig for default personality
3. Change to other personality with other sig
4. You now have two signatures in body

Comment 3

[Mike Cowperthwaite]

This is the reason "below the quote" is annotated with "recommended."

Using the "below my reply" setting requires Mozilla to not use the "-- " sig 
separator so as not to treat all the quoted text as part of the sig.  When 
changing identities, that separator is what's used to locate the sig to swap it 
with the new identity; anything that's *not* a sig is assumed to be text, and 
the new identity's sig is inserted into that text.

Comment 4

[Mike Cowperthwaite]

Whoops -- found a dupe.

*** This bug has been marked as a duplicate of 218346 ***