249809 - wrong referer sent for generated content linked from stylesheet

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Description:  This is similar to bug 249168 and bug 249171.  When the 'content'
property contains a url() value, we should send the stylesheet URL as the HTTP
Referer header when retrieving the URL.

Steps to Reproduce:  Load http://dbaron.org/css/test/2004/referer/content
Actual results: red square
Expected results: green square

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: work in progress

Doesn't compile yet; the new content class needs to live in content.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I talked to jst about the new file and it was ok with him.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 152458 [details] [diff] [review]
patch

>Index: content/shared/src/nsStyleStruct.cpp

>+PRBool nsStyleContentData::operator==(const nsStyleContentData& aOther)

>+  return mContent.mString == aOther.mContent.mString;

I know you just copied this, but that should be a string compare, not a pointer
compare.

>Index: content/html/style/src/nsCSSDataBlock.cpp
>                 case eCSSType_ValueList:
>+                    if (iProp == eCSSProperty_content) {

Add a comment below the if block that we're falling through on purpose?

>Index: content/svg/document/src/Makefile.in

This isn't really relevant to this bug.

>Index: content/xul/content/src/nsXULElement.h

Nor is this.

>Index: layout/html/style/src/nsCSSFrameConstructor.cpp

>@@ -1353,48 +1353,44 @@ nsCSSFrameConstructor::CreateGeneratedFr
>+    if (!data.mContent.mImage) {
>       // CSS had something specified that couldn't be converted to a URI object

"image object"

r+sr=bzbarsky with those nits

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #3)
> >Index: content/svg/document/src/Makefile.in
> This isn't really relevant to this bug.

> >Index: content/xul/content/src/nsXULElement.h
> Nor is this.

They actually were relevant (although a good bit more was needed) before I moved
a bunch of nsStyleContentData functions from the .h file to the .cpp file, and I
figured they were good changes anyway...

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-07-14 15:19 -0700.