250088 - Page setup scale NaN (not a number) when entering >=1 period

Status: NEW

(Toolkit :: Printing, defect)

Description

[Richard Corbin]

The page setup screen (File > Page Setup) allows the user to enter 1 or more
periods / fullstops (i.e. "."). Then when it comes to printing or viewing print
preview the page is blank (or contains very little), other than header/footer.

Steps to Reproduce:
1. File > Page Setup
2. Enter 'scale' of ".", without quotes. Should stop user here as it does with
letters (a,b,c,etc not allowed).
3. Click OK.
4a. File > Print Preview
4b. File > Print ... Print a copy

Actual Results:
4a. Print preview shows nothing or very little (other than header/footer)
4b. Printed copy shows nothing or very little (other than header/footer)

Expected Results:
Using 1 or more periods/fullstops in the 'scale' entry field should not be
permitted. (and therefore printing/previewing would work fine).

Other info:
Repeat steps 1 to 3 from above and go back into 'File > Page Setup' and the
scale field shows "NaN" (not a number) instead of an actual scale.

Comment 1

[Richard Corbin]

Experienced on:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040704
Firefox/0.9.0+

Comment 2

[Aaron Graves]

Also experienced on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7)
Gecko/20040626 Firefox/0.9.1

Comment 3

[Richard Corbin]

Perhaps the 'Page Setup' dialog box should use the dropdown for "scale" that is
already being used in the 'Print Preview' dialog. This could be an easy
work-around / quick fix for this bug.

Comment 4

[Jason Barnabe (np)]

Attachment: change scale textbox to combo box

This patch changes the textbox to a combo box like the one in print preview. It
 also enables print scale saving.

Comment 5

[Benjamin Smedberg]

Comment on attachment 173442 [details] [diff] [review]
change scale textbox to combo box

I don't do UI review, sorry.

Comment 6

[Jason Barnabe (np)]

Comment on attachment 173442 [details] [diff] [review]
change scale textbox to combo box

mconnor's busy

Comment 7

[Mike Connor [:mconnor]]

hyatt's even worse than me

First problem is that I don't get the rationale behind the chosen intervals:
30,40,50,60,70,80,90,100,125,150,175,200 doesn't make a whole lot of sense off
the bat.

Second problem is that you don't appear to show the Custom value, which could be
bad.  Something like this is required.

150%
175%
200%
----
Shrink To Fit
----
Custom (112%)

Third, Shrink To Fit isn't as accurate as the current text, since we'll only
compress enough to fit horizontally, and fit on multiple pages vertically as
needed.  So its imprecise where we have a precise answer.

I'm more curious as to whether other browsers even offer scaling, or if they
just do what we do by default, and don't show UI for it.

All that aside, the patch looks fairly decent, as is.

Comment 8

[Jason Barnabe (np)]

(In reply to comment #7)
> hyatt's even worse than me

Well geez, who's good? :-)


Essentially, this patch implements the suggestion in comment #3: 

"Perhaps the 'Page Setup' dialog box should use the dropdown for "scale" that is
already being used in the 'Print Preview' dialog."

so I wasn't looking to make improvements on the Scaling dialog on Print Preview.
I'm willing to do so, though.

> First problem is that I don't get the rationale behind the chosen intervals:
> 30,40,50,60,70,80,90,100,125,150,175,200 doesn't make a whole lot of sense off
> the bat.

I don't understand it either, but if you give me some new numbers to use, I'll
change it.

> Second problem is that you don't appear to show the Custom value, which could be
> bad.  Something like this is required.
> 
> 150%
> 175%
> 200%
> ----
> Shrink To Fit
> ----
> Custom (112%)

I'm not so sure about this. The "Custom..." option opens a prompt for a custom
value. If it displayed as "Custom (112%)", it wouldn't indicate it would open a
prompt ("...") and it also wouldn't set the scaling value to 112%. Perhaps we
could display it as "Custom..." when it's not selected and "Custom (112%)..."
when it is?

> Third, Shrink To Fit isn't as accurate as the current text, since we'll only
> compress enough to fit horizontally, and fit on multiple pages vertically as
> needed.  So its imprecise where we have a precise answer.

I'll switch it to "Shrink To Fit Page Width" in both places.

> I'm more curious as to whether other browsers even offer scaling, or if they
> just do what we do by default, and don't show UI for it.

After a quick check of my system, IE doesn't (the drop-down it has is zoom) and
Opera does.

> All that aside, the patch looks fairly decent, as is.

Thanks. Would that have been an r+ is it was assigned to you (or will it be if I
implement X, Y, and Z?)

Comment 9

[Mike Connor [:mconnor]]

Maybe, I didn't look at it in depth, but its a lot of "sane things" happening
which is good.

I'm a little out of it, but I'll try to respond to the Custom thing in the morning.
I don't have better numbers, but I would think that something like 10%
increments from 60% to 140% would be more sane/useful.  Also something for
further thought.

Comment 10

[Jason Barnabe (np)]

For the record, bug 127857 introduced the values used, but there doesn't seem to
be any explanation on why those values were chosen.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 173442 [details] [diff] [review]
change scale textbox to combo box

Hyatt's not reviewing. Does this still apply?

Comment 12

[Jason Barnabe (np)]

If you're asking whether or not this is still a bug, yes. If you're asking whether this patch is still viable, probably not because of rot. I'd be willing to fix it up pending decisions on the "Custom" drop down item and the scale values to use.