250186 - new mail notification sound freezes browser/mail client during sound playback

Status: RESOLVED DUPLICATE of bug 110385

(Core :: XUL, defect)

Description

[Harlan Harris]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510

When I set the mail client to play a .wav file when new mail is received, the
entire Mozilla program (browser and mail client) freezes for the several seconds
that the sound is playing. 

Reproducible: Always
Steps to Reproduce:
1. Set the mail notification to a custom wave file that's, say, 5 seconds long.
2. Send yourself mail while using the browser.

Actual Results:  
When the new-mail sound starts to play, the browser locks up until the sound stops.

Expected Results:  
Presumably, spun the new-mail sound playing into a separate thread so that other
activity can occur in the background.

Comment 1

[Tuukka Tolvanen (sp3000)]

*** Bug 264996 has been marked as a duplicate of this bug. ***

Comment 2

[Tuukka Tolvanen (sp3000)]

confirmed, dup and thunderbird aviary 2004-10-12-14Z.

Comment 3

[Tuukka Tolvanen (sp3000)]

related/dep/dup bug from bug 264996: bug 110385

Comment 4

[Pete Collins (MDG)]

Jan has a patch for this.

Comment 5

[Jan Varga [:janv]]

Attachment: patch for gtk2

Comment 6

[Jan Varga [:janv]]

this patch is actually for mozilla 1.6, will try on trunk

Comment 7

[Jan Varga [:janv]]

Attachment: patch gtk2/trunk

Comment 8

[Pete Collins (MDG)]

Jan, I tried the patch on a trunk build of Thunderbird. Before I applied the patch, I can play a custom wav sound. After I applied the patch, I don't hear the sound playing any more and I don't see any errors on the console.

I'm not running a debug build. Will do one.

Comment 9

[massey]

There is a change to the nsISound uuid in the patch at https://bugzilla.mozilla.org/show_bug.cgi?id=207102 that breaks nsISound, revert the uuid change and things work. Hopefully that breakage will be reverted. see https://bugzilla.mozilla.org/show_bug.cgi?id=207102#c25

But after this patch is applied system sound will play but not a sound url. Seems like its failing at nsSound::Play

Comment 10

[massey]

Jan in the trunk patch:

+    if (gEsdRef == -1)
         return NS_ERROR_FAILURE;

is always -1
I did this:

    if (!gEsdRef)
         return NS_ERROR_FAILURE;

And async sound works. I also had to revert the uuid change I mentioned in comment 9 

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Any reason bug 110385 was not marked as a duplicate of this one?

Comment 14

[Wayne Mery (:wsmwk)]

(In reply to comment #12)
> Any reason bug 110385 was not marked as a duplicate of this one?

perhaps moot, comment 16 points out perhaps HTML5's audio should be used.
bug 110385 has dependencies set, so suggest this bug be duped to 110385.
and I would think we want this for TB3.