250313 - display "match case" option for Find Toolbar

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, enhancement)

Description

[sairuh (rarely reading bugmail)]

the Find dialog had a checkbox for matching case, and while the Find Toolbar has
a means(*) of matching case, it isn't obvious.

(*)iirc: if lower-case chars are entered, then find is case-insensitive. but
when an upper-case char is entered, then the find becomes case-sensitive (does
this state start with the first upper-case char typed in?). question: what would
happen if the user want to find something that was soley in lower-case?

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

-> Find Toolbar component.

Comment 2

[Blake Ross]

Minusing this for now.  Mike, if you can create a patch that does a
case-sensitive find if there's a capital letter in the find string, I'll take it.

Comment 3

[Peter van der Woude [:Peter6]]

*** Bug 261868 has been marked as a duplicate of this bug. ***

Comment 4

[Brendan Eich [:brendan]]

What if I'm searching for a lowercase string and there would be thousands of
false positives with mixed or uppercase?

If it's a regression for enough users, it may be a regression worth fixing.  Any
loss of functionality is a regression in plain English, but some may be worth
the gain in simplicity.

I don't see that win here -- the Find toolbar is neither simple nor out of
control with options.  There is no mitigation from faster find, and not enough
from uppercase secretly triggering case-sensitivity.  That kind of implicit
option can confuse people badly, even as it doesn't solve the lowercase-only
match problem.

/be

Comment 5

[chris hofmann]

lets try and get this fixed.

Comment 6

[Asa Dotzler [:asa]]

This shouldn't have any localization impact because a string is available from
http://lxr.mozilla.org/seamonkey/source/toolkit/locale/finddialog.dtd (I think).

Comment 7

[Blake Ross]

Fixed.

Comment 8

[sairuh (rarely reading bugmail)]

see regression bug 264789.

Comment 9

[sairuh (rarely reading bugmail)]

also see bug 264801.

Comment 10

[Worcester12345]

fixed-aviary flag?