250591 - Conversion of boolean conditions in SQL statements for better db independence (take 2)

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[David Lawrence [:dkl]]

One more spot was discovered by Tomas Kopal where a boolean condition needs to
be sanitized for better db independence. Patch forthcoming.

Comment 1

[David Lawrence [:dkl]]

Attachment: patch for additional boolean fix (v1)

Comment 2

[David Lawrence [:dkl]]

Seeking approval for checkin.

Comment 3

[Joel Peshkin]

getting a bit ahead of ourselves :-)

Comment 4

[David Lawrence [:dkl]]

Ack, you're right. I meant review? but got the two mixed up, and then to top it
off hit the + instead of ?. 

/me heads out for more coffee ;)

Comment 5

[Joel Peshkin]

dkl: I'm assuming that there are a whole bunch of pgsql changes that will need
to go in that won't be on 2.18.  Wouldn't it be better to target this for (very
early) 2.19??

Comment 6

[David Lawrence [:dkl]]

I would think this one would be ok to get into 2.18 since it is not PgSQL
specific really. Plus this is part of my trying to break the huge PgSQL patch
down into smaller generic pieces for easier review. But I am up for whatever
others think.

Comment 7

[Dave Miller [:justdave]]

ehhh...  I don't want to mess with this this close to branch point.  Let's check
it in on the trunk after we branch (that's happening later tonight).

2.18 isn't going to have multi-DB support anyway, so there's no reason it has to
be there.

Comment 8

[Joel Peshkin]

*** Bug 250832 has been marked as a duplicate of this bug. ***

Comment 9

[David Lawrence [:dkl]]

Just as a refresher, the approval that justdave granted means it is ok to check
this in against HEAD since 2.18 is not on it's own branch?

Tnanks

Comment 10

[Tomas Kopal]

What is this one still waiting for? ;-)

Comment 11

[Vlad Dascalu]

David: it's ok for you to check this in on the tip (on the HEAD).

You don't need to worry about branches (2_16, 2_18 etc).

Comment 12

[David Lawrence [:dkl]]

Thanks, will get it in. 

Comment 13

[Tomas Kopal]

Another month gone, another whine :-). What is this waiting for now? :-)

Comment 14

[Vlad Dascalu]

Checking in request.cgi;
/cvsroot/mozilla/webtools/bugzilla/request.cgi,v  <--  request.cgi
new revision: 1.15; previous revision: 1.14
done