One more spot was discovered by Tomas Kopal where a boolean condition needs to be sanitized for better db independence. Patch forthcoming.
Assignee: justdave → dkl
Status: NEW → ASSIGNED
Seeking approval for checkin.
getting a bit ahead of ourselves :-)
Flags: approval2.18+ → approval2.18?
Ack, you're right. I meant review? but got the two mixed up, and then to top it off hit the + instead of ?. /me heads out for more coffee ;)
dkl: I'm assuming that there are a whole bunch of pgsql changes that will need to go in that won't be on 2.18. Wouldn't it be better to target this for (very early) 2.19??
I would think this one would be ok to get into 2.18 since it is not PgSQL specific really. Plus this is part of my trying to break the huge PgSQL patch down into smaller generic pieces for easier review. But I am up for whatever others think.
ehhh... I don't want to mess with this this close to branch point. Let's check it in on the trunk after we branch (that's happening later tonight). 2.18 isn't going to have multi-DB support anyway, so there's no reason it has to be there.
Flags: approval2.18? → approval2.18-
Target Milestone: --- → Bugzilla 2.20
*** Bug 250832 has been marked as a duplicate of this bug. ***
Just as a refresher, the approval that justdave granted means it is ok to check this in against HEAD since 2.18 is not on it's own branch? Tnanks
What is this one still waiting for? ;-)
David: it's ok for you to check this in on the tip (on the HEAD). You don't need to worry about branches (2_16, 2_18 etc).
Thanks, will get it in.
Another month gone, another whine :-). What is this waiting for now? :-)
Checking in request.cgi; /cvsroot/mozilla/webtools/bugzilla/request.cgi,v <-- request.cgi new revision: 1.15; previous revision: 1.14 done
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.