250656 - Extension/Theme Managers do not scroll partially shown items into view

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P4)

Description

[Devin J. Pohly [:djpohly]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2

When viewing the Extension or Theme managers in a window that is too small for
all installed components, clicking to select a partially shown item should
scroll the item into view.  If the window is too small for one item, it should
at least scroll to the top of the window.  (NB: This also happens in the
Downloads window.)  Sorry if this is double-posted as BZ did not respond upon
first click of Submit.

Reproducible: Always
Steps to Reproduce:
1. Run Firefox.
2. Install (if necessary) at least two themes/extensions.
3. Open manager and size so that there is an item partially showing.
4. Click to select the item.

Actual Results:  
The item is selected, but still partially out of view.

Expected Results:  
(1) If the window is big enough for the whole item, scroll the item to the
bottom of the window.
(2) If the window is not big enough for the whole item, scroll the item to the
top of the window.

Using default theme.

Comment 1

[Oleg Sidletskiy]

*** Bug 250654 has been marked as a duplicate of this bug. ***

Comment 2

[Oleg Sidletskiy]

good point, lets see if the devs agree with it..

Comment 3

[Blake Ross]

If anyone wants to fix this, it might just be a matter of calling
scrollSelectionIntoView (or whatever) onclick. But I doubt anyone will get to it
for 1.0 unless someone contributes a patch.

Comment 4

[Nian Liu(n/a in a long time)]

theme/extensions use custom widget which is with xbl bindings in an hbox. for
me, seems difficult:(

Comment 5

[Devin J. Pohly [:djpohly]]

I am wondering if this bug is related to Bugs 247065 and 245388.  Perhaps we
could kill three birds (foxes?) with one stone by ensuring/scrolling the
selection into view whenever a new extension is selected (by any means).  This
would cover both the mouse click and keyboard methods, and possibly scroll the
last-selected extension into view when it is selected upon creation of the window.

(I'm not sure how plausible this is - I haven't done anything with Mozilla
source before.)

Comment 6

[Nickolay_Ponomarev]

This will be fixed with a patch for bug 235203.

Comment 7

[Asa Dotzler [:asa]]

p4 priority - not a blocker. if a patch materializes, please nominate for aviary
approval. 

Comment 8

[Jaime Mitchell (use [e-mail] for email)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050616
Firefox/1.0+ ID:2005061605

As described by comment 0

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050617
Firefox/1.0+ ID:2005061712

WFM - Extension manager scrolls the selected item into full view.

Fixed by the checkin for bug 285584

-> Fixed