235203 - Download Manager doesnt scroll with keypress (but focus changes to next download)

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect, P1)

Description

[Richard Biddle]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20040102 Firebird/0.7+

In download manager, pressing arrow keys, page up/down doesn't scroll the list

Reproducible: Always
Steps to Reproduce:
1. Open download manager with more files listed than can fit in window
2. Press down arrow
3. Hilight moves down the list and out of view

Actual Results:  
doesnt scroll

Expected Results:  
scroll

Comment 1

[Ali Ebrahim]

Confirming on:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040302
Firefox/0.8.0+

--> NEW
--> All/All

Comment 2

[Nickolay_Ponomarev]

ok, I tried to fix this, but failed.

I thought that I needed nsIScrollBoxObject::ensureElementIsVisible(), so I
changed the <vbox> (bound to <view> with xbl) to <scrollbox> (as I think there's
some magic that makes nsIScrollBoxObject available for <scrollbox> elements only).

I was then able to bring the selected element in view putting the following code
in richview.xml#richview implementation:
>var kids = document.getAnonymousNodes(this);
>scrollBoxObject = kids[0].boxObject.QueryInterface(
Components.interfaces.nsIScrollBoxObject);
>scrollBoxObject.ensureElementIsVisible(this._selected);

The problem I had was - I couldn't make the scrollbox show the scrollbar. 
"overflow: auto" on scrollbox or its parent didn't work.

Comment 3

[Max]

I am using FireFox 1.0 and I'm having this problem. Pressing up/down keys in the
download manger doesn't scroll down. I think the extension manager may also have
this problem.

Firefox is supposed to be fast and easy to use, and being able to navigate
around a bit with the keyboard is part of this. I presume that this bug is
extremely easy to fix so could you please fix it immediately.

Many thanks.

Comment 4

[Max]

I'm using the latest build of Firefox from today (26th jan 2005) and this
problem is still partially there. When scrolling down using the keyboard, it
does go down but the highlight still moves out of view.

Comment 5

[Marius Gundersen]

Same with extensions and theme window. Bookmarks and history work, probably
because they are trees. Its the same if you tab through the options dialog.

Comment 6

[Jeremy Priest]

If you haven't highlighted an item in the Download Manager the scrolling works
as expected. 
-- The up and down arrow keyboard arrow keys scrolls the internal window up and
down.

If you do highlight an item it does not work as expected.
-- Instead the scrollbar does not move along with the current hightlighted item
(although the highlight moves) in the internal window; the scrollbar still acts
like it was when you don't have anything highlighted.

This is a bug seems to not be properly focusing the highlighted item with the
scrollbar.

Comment 7

[Bouiaw]

I begin to work on this bug, but it's my first try, so I don't know if I will
succeed !

Comment 8

[Nickolay_Ponomarev]

Bouiaw, I think it would be wise to consult with Mike Connor and Aaron Leventhal
about this first. There may (or may not) be general changes about download
manager implementation (see bug 256243 and bug 285584).

If no big changes happen, I think the only way to fix this bug is to use the
widget from bug 285005 as the container for items in the rich view.

Comment 9

[Jaime Mitchell (use [e-mail] for email)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050616
Firefox/1.0+ ID:2005061605

Same as comment 4

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050617
Firefox/1.0+ ID:2005061712

WFM

Fixed by the checkin for bug 285584

Resolving Fixed.

Comment 10

[Phil Ringnalda (:philor)]

*** Bug 305308 has been marked as a duplicate of this bug. ***

Comment 11

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381