250877 - editgroups dies with an sql error if a group hierarchy change is resubmitted

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Joel Peshkin]

editgroups.cgi compares the new selections with the old choices and generates
inserts.  If the form is resubmitted with changes already in place (and probably
if 2 administrators midair, since we lack detection on admin pages), editusers
will try to insert duplicate records and die with mysql errors.

Comment 1

[Joel Peshkin]

*** Bug 250876 has been marked as a duplicate of this bug. ***

Comment 2

[Dave Miller [:justdave]]

Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.

Comment 3

[Frédéric Buclin]

We have this problem in several places among admin pages. The problem is that in
order to avoid new requests to the DB, we use values saved in hidden fields.

So the question is: do we want to remove all these hidden fields and request the
DB again to make sure there is no conflict or not (due to performance issues for
instance)? Personally, my answer is "yes"!

Comment 4

[Frédéric Buclin]

Attachment: patch, v1

This is a first step towards the use of $group->update() and $group->_check_foo().

Comment 5

[Max Kanat-Alexander]

Comment on attachment 256859 [details] [diff] [review]
patch, v1

I hate to say it, but I've basically already fixed all of this in bug Bug 354627.

Comment 6

[Frédéric Buclin]

the SQL crash has gone thanks to bug 354627. There are still some SQL queries in editgroups.cgi which should go away IMO, but that's not part of this bug.