251050 - Use installTrigger.install for install link and allow developer defined icons

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Richard Klein]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040712 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040712 Firefox/0.9.1+

It would be good to use the installTrigger javascript object for installing
extensions and themes.  That would allow for a nicer name to show up in the xpi
install dialog.  The developer could also supply an image the installer dialog
displays.  This would be great in conjunction with bug 246812.

Reproducible: Always
Steps to Reproduce:
1.  go to
http://update.mozilla.org/extensions/showlist.php?type=E&application=firefox
2.  click install link on any extension listed

Actual Results:  
Install dialog shows filename.xpi and generic image.

Expected Results:  
Install dialog should show extension/theme name and developer defined image.

See url for Firefox's recommend install procedure.

Comment 1

[Wolf [:wolf]]

Bouncing this to nobody to get it off my buglist since it's blocked by another bug.

Comment 2

[Wolf [:wolf]]

Taking this, for update-beta, based on bugs like Bug 265135. I'm going to
investigate changing how the installTrigger calls are handled, and attempt to
unbreak theme downloadcounts, thereby removing the blocking bug 246754.

Comment 3

[Wolf [:wolf]]

Bug 267822 landed a patch that implemented installTrigger for the live update site.

This bug will remain open though, per Comment #2, this bug is doing this right
for update-beta, including not breaking the downloadcounts which the fix in Bug
267822 did.

Comment 4

[Wolf [:wolf]]

Bulk Moving Web Site bugs to new component.
(Filter: massumowebsitespam)

Comment 5

[Wolf [:wolf]]

Attachment: Patch

Add and Use JS installTrigger.

Comment 6

[Wolf [:wolf]]

Checked in.

Comment 7

[Wolf [:wolf]]

This combined the two install.php's in extensions/ and themes/ into one in core/. 

Also, there's a DB schema change here... courtesy of Giorgio Maone, in Bug 267822.
alter table t_downloads 
  add index i_downloads_type(type), 
  add index i_downloads_date(date);

This should fix up downloadcounts to be useable again.

Comment 8

[nrlz]

It would be nice to move the javascript to an "onclick" event handler instead of
having it in the href. That way people can still right-click and do a "Save Link
As..." to archive copies of their favourite extensions.

<a href="extension.xpi"
onclick="InstallTrigger.install({'MyExtension1.0':'extension.xpi'});return
false;">(Install Now)</a>