251098 - Context menu key doesn't work in Theme & Extension manager

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040712
Firefox/0.9.1+

1. Open Theme manager.
2. Press the context-menu key on the keyboard (next to the right Ctrl key), or
press Shift+F10.

Result: Nothing happens.
Expected: Bring up a context menu, as if I had right-clicked the selected theme.

This bug has the access keyword because the commands on this context menu,
"Visit Home Page" and "About foo...", are completely inaccessible from the keyboard.

Comment 1

[sairuh (rarely reading bugmail)]

also occurs in the Extension mgr, so updating summary (Jesse, let me know if
you'd prefer a separate bug, though).

also an issue on Linux (tested on fedora core 2) and Mac OS X 10.3.4 (where the
shortcut would be Control+Spacebar).

taking QA and nominating for 1.0. but I'd imagine this would be a non-trivial
fix, right?

Comment 2

[Jesse Ruderman]

Theme and Extension manager share a lot of frontend code, so I imagine the same
patch will fix both.

I don't know how hard this will be to fix.

Comment 3

[Nian Liu(n/a in a long time)]

shift+f10 works not same as right click in most scenerios( such as on an URL ).
or should it?

Comment 4

[Aaron Leventhal]

Shift+F10 should work the same as right click, but the target is the focus
intead of what's under the mouse pointer.

Comment 5

[Nian Liu(n/a in a long time)]

Aaron, 

what i meaned is that in most scenerios, current implementation makes
context-menu key and shift+F10 works different from right click. an example is
that when mouse on a url link.

Comment 6

[Nian Liu(n/a in a long time)]

so i think much more work need to be done if we want context-menu key and
shift+F10 works same with right click

Comment 7

[Jesse Ruderman]

I have a patch.

Comment 8

[Jesse Ruderman]

Attachment: patch

Fixes this bug by moving the context menu from the individual extension items
to the list view.  Also makes some more things in the Themes/Extensions windows
focusable, fixing bug 251099, bug 251101, and bug 251102.

Comment 9

[Jesse Ruderman]

Err, I lied.  The patch doesn't fix bug 251101.

Comment 10

[Ryan Polk (Quark)]

Can this be patched so that the extension currently selected shows better focus?
 With this patch it looks the same whether or not it has focus.

Comment 11

[Ryan Polk (Quark)]

This patch is now outdated, Ben reworked the window.
The context menu key still does not work, and "Get More ..." doesn't take focus,
but the Uninstall/Update/Options will take focus.

See bug 257677 for some more info.

Comment 12

[Asaf Romano (gone)]

not a mac bug, removing blocking-aviary1.0mac? flag.

Comment 13

[Jesse Ruderman]

Attachment: Updated patch

Fixes this bug, bug 251102, the parts of bug 251099 that Ben missed.

Comment 14

[Mike Connor [:mconnor]]

Comment on attachment 160897 [details] [diff] [review]
Updated patch

looks fine to me, but I'd want some input from ben as to why he made the focus
setting "ignore" explicitly.

Comment 15

[Jesse Ruderman]

Ben already removed the corresponding "-moz-user-focus: ignore" lines for
Winstripe.  The patch removes the ones he missed in Qute and Pinstripe.

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 160897 [details] [diff] [review]
Updated patch

a=[e-mail] please land asap

Comment 17

[Jesse Ruderman]

Fixed aviary and trunk.

Comment 18

[sairuh (rarely reading bugmail)]

vrfy'd fixed on linux fc2 (2004100809-0.9+) and mac os x 10.3.5 (2004100805-0.9+).