Context menu key doesn't work in Theme & Extension manager

VERIFIED FIXED

Status

()

Toolkit
Add-ons Manager
--
major
VERIFIED FIXED
14 years ago
10 years ago

People

(Reporter: Jesse Ruderman, Assigned: Jesse Ruderman)

Tracking

(Blocks: 1 bug, {access, fixed-aviary1.0})

unspecified
access, fixed-aviary1.0
Points:
---
Bug Flags:
blocking-aviary1.0 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [have patch] - ready to land)

Attachments

(1 attachment, 1 obsolete attachment)

9.95 KB, patch
mconnor
: review+
Ben Goodger (use ben at mozilla dot org for email)
: approval-aviary+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040712
Firefox/0.9.1+

1. Open Theme manager.
2. Press the context-menu key on the keyboard (next to the right Ctrl key), or
press Shift+F10.

Result: Nothing happens.
Expected: Bring up a context menu, as if I had right-clicked the selected theme.

This bug has the access keyword because the commands on this context menu,
"Visit Home Page" and "About foo...", are completely inaccessible from the keyboard.
also occurs in the Extension mgr, so updating summary (Jesse, let me know if
you'd prefer a separate bug, though).

also an issue on Linux (tested on fedora core 2) and Mac OS X 10.3.4 (where the
shortcut would be Control+Spacebar).

taking QA and nominating for 1.0. but I'd imagine this would be a non-trivial
fix, right?
Flags: blocking1.0mac?
Flags: blocking-aviary1.0?
OS: Windows XP → All
QA Contact: bugs → bugzilla
Hardware: PC → All
Summary: Context menu key doesn't work in Theme manager (view never has focus) → Context menu key doesn't work in Theme & Extension manager (view never has focus)
(Assignee)

Comment 2

14 years ago
Theme and Extension manager share a lot of frontend code, so I imagine the same
patch will fix both.

I don't know how hard this will be to fix.

Updated

14 years ago
Flags: blocking-aviary1.0? → blocking-aviary1.0+
shift+f10 works not same as right click in most scenerios( such as on an URL ).
or should it?

Comment 4

14 years ago
Shift+F10 should work the same as right click, but the target is the focus
intead of what's under the mouse pointer.
Aaron, 

what i meaned is that in most scenerios, current implementation makes
context-menu key and shift+F10 works different from right click. an example is
that when mouse on a url link.
so i think much more work need to be done if we want context-menu key and
shift+F10 works same with right click
(Assignee)

Updated

14 years ago
Summary: Context menu key doesn't work in Theme & Extension manager (view never has focus) → Context menu key doesn't work in Theme & Extension manager
(Assignee)

Comment 7

14 years ago
I have a patch.
(Assignee)

Comment 8

14 years ago
Created attachment 157032 [details] [diff] [review]
patch

Fixes this bug by moving the context menu from the individual extension items
to the list view.  Also makes some more things in the Themes/Extensions windows
focusable, fixing bug 251099, bug 251101, and bug 251102.
(Assignee)

Updated

14 years ago
Attachment #157032 - Flags: review?(bugs)
(Assignee)

Comment 9

14 years ago
Err, I lied.  The patch doesn't fix bug 251101.

Comment 10

14 years ago
Can this be patched so that the extension currently selected shows better focus?
 With this patch it looks the same whether or not it has focus.

Comment 11

14 years ago
This patch is now outdated, Ben reworked the window.
The context menu key still does not work, and "Get More ..." doesn't take focus,
but the Uninstall/Update/Options will take focus.

See bug 257677 for some more info.
not a mac bug, removing blocking-aviary1.0mac? flag.
Flags: blocking-aviary1.0mac?
(Assignee)

Comment 13

13 years ago
Created attachment 160897 [details] [diff] [review]
Updated patch

Fixes this bug, bug 251102, the parts of bug 251099 that Ben missed.
Attachment #157032 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #160897 - Flags: review?(mconnor)
Attachment #157032 - Flags: review?(bugs)
Comment on attachment 160897 [details] [diff] [review]
Updated patch

looks fine to me, but I'd want some input from ben as to why he made the focus
setting "ignore" explicitly.
Attachment #160897 - Flags: review?(mconnor) → review+
(Assignee)

Comment 15

13 years ago
Ben already removed the corresponding "-moz-user-focus: ignore" lines for
Winstripe.  The patch removes the ones he missed in Qute and Pinstripe.
(Assignee)

Updated

13 years ago
Attachment #160897 - Flags: approval-aviary?
Comment on attachment 160897 [details] [diff] [review]
Updated patch

a=ben@mozilla.org please land asap
Attachment #160897 - Flags: approval-aviary? → approval-aviary+

Updated

13 years ago
Whiteboard: [have patch] - ready to land
(Assignee)

Comment 17

13 years ago
Fixed aviary and trunk.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
vrfy'd fixed on linux fc2 (2004100809-0.9+) and mac os x 10.3.5 (2004100805-0.9+).
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.