25152 - [regression] Autoreg doesn't descend into subdirs of components/

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Suresh Duddi (gone)]

I checked this on both win and linux and it doesnt look like autoreg is
descending into subdirs of components/

Kins needs that because he is installing spellchecker into
components/spellchecker

Comment 1

[kinmoz]

The bug is in the method nsLocalFile::IsDirectory(). It's returning a value that
is not PR_TRUE or PR_FALSE:

  *_retval = (PRBool)( mFileAttrData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY);

It can be fixed like this:

    *_retval = (PRBool)( mFileAttrData.dwFileAttributes &
FILE_ATTRIBUTE_DIRECTORY != 0);

Comment 2

[Doug Turner (:dougt)]

Nice find.  you can also remove the cast to (PRBool).  Would you like me to 
check this in, or would you like to?  I bet all three platforms will have this 
problem.

Comment 3

[Doug Turner (:dougt)]

unix does this:

*_retval = S_ISDIR(mCachedStat.st_mode);

Comment 4

[kinmoz]

You can check the fix in if you'd like. :-)

Comment 5

[Doug Turner (:dougt)]

*** Bug 6864 has been marked as a duplicate of this bug. ***

Comment 6

[Doug Turner (:dougt)]

I beleive that this is now fixed.  Are you still seeing this?

To reproduce:

1.  Create a directory in the components directory:
2.  Copy a component .so (.dll) in this new directory.
3.  Blow away the component.reg file in bin.
4.  Start mozilla.
5.  Watch the debug window to for the component that you copied to load.

Comment 7

[Doug Turner (:dougt)]

adding beta1 keyword and setting m14 checkpoint.

Comment 8

[kinmoz]

I don't know if this is related or not bug ... Things work fine if I start the
application and there is no component.reg. The spellchecker runs fine.

If I restart the application, the spellchecker does not start up. I see the
following error in the shell:


Check Spelling starting...
**************************************************
nsNativeComponentLoader: GetFactory(Y:\ns\dist\WIN32_D.OBJ\bin\components\spellc
hecker.dll) Load FAILED with error: error 0
**************************************************
*** Exception error from Spell Checker

FYI: The spellchecker uses the generic factory template that all the other
modules use.

Comment 9

[Doug Turner (:dougt)]

sounds like:
http://bugzilla.mozilla.org/show_bug.cgi?id=25277

Try blowing away your component.reg file until I check the fix in for 25277.

Comment 10

[Suresh Duddi (gone)]

No probably not. His path looks ok. I would suspect a undefined symbol in your 
spell checker dll at this point.

Comment 11

[leger]

Putting on PDT+ radar for beta1.

Comment 12

[Doug Turner (:dougt)]

marking as fixed.

Comment 13

[kinmoz]

Dp,

It's not an undefined symbol. It looks like the registry is not keeping track of
the fact that the dll is in  a subdirectory. I put a breakpoint in
nsNativeComponentLoader::GetFactory() and found that it is trying to load the
spellchecker.dll in the components directory ... not the components/spellchecker
directory.

Comment 14

[Doug Turner (:dougt)]

okay.  I fixed the problem last night.  We were not saving relative paths
correctly.

Comment 15

[leger]

Marking Verified per dougt comments.  Reopen if still a problem.

Comment 16

[Dawn Endico]

moving from architecture product to Browser. Architecture product is going
away.