251911 - Silly ThrowUserError bits in attachment.cgi

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Christian Reis]

There are some missing variables in ThrowUserError bits in attachment.cgi.

Comment 1

[Christian Reis]

Attachment: kiko_v1: cleanups and fix

Basically, the problem here is that the attachment ID isn't getting echoed in
the error screen. But why not kill some $::FORM callsites while we're at it,
right?

Comment 2

[Christian Reis]

Attachment: kiko_v2: deal with madness with attach_id

This code is seriously mad.

Comment 3

[Christian Reis]

Well, not so much the code, but the interfaces.

Comment 4

[Christian Reis]

Uhm. It appears I coded this patch while on medication. It's got some serious
thinkos in it. 

Comment 5

[Christian Reis]

Attachment: kiko_v3: same intent, less drugs

Comment 6

[Christian Reis]

Attachment: kiko_v4: remove this silly vars attach_id

which happens to not be used anywhere. Don't we all love crud?

Comment 7

[Christian Reis]

/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.60; previous revision: 1.59

One more bit of crud extinguished from the world. Bit by bit we fight back --
thanks!

Comment 8

[Frédéric Buclin]

I think we should have it for 2.18 as well!

Comment 9

[Frédéric Buclin]

This patch applies cleanly to the 2.18 branch.

Comment 10

[Vlad Dascalu]

Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.58.2.2; previous revision: 1.58.2.1
done

Comment 11

[Vlad Dascalu]

*** Bug 248299 has been marked as a duplicate of this bug. ***

Comment 12

[Shane H. W. Travis]

*** Bug 248297 has been marked as a duplicate of this bug. ***