251996 - Find Toolbar is broken for FAYT after it closes if text is not found on some pages

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Michael Clackler]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040714 Firefox/0.9.1+ (MOOX-AV)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040714 Firefox/0.9.1+ (MOOX-AV)

If the desired text is not found before the toolbar closes, the toolbar will not
re-open using FAYT unless you exit the tab, and then re-enter the tab.  This is
true for not found strings using FAYT or using Ctrl-F to open the bar.  FOr some
reason, it does not occur on all pages.  I can repeat the problem using
http://www.hoovers.com/free/

Reproducible: Always
Steps to Reproduce:
1.open the find toolbar using FATY (I use "/" to open), or use CTRL-F
2.Enter a text string that does not exist in the document ("zz" works most of
the time)
3.Allow the find toolbar to close (or close it if you used CTRL-F)
4.Open the find toolbar using FAYT (I use "/" to open)

Actual Results:  
The desired string "zz" was not found in the document using the original find
request.  Upon attempting to re-open the find toolbar using FAYT, the toolbar
does not open.

Expected Results:  
The toolbar should re-open using FAYT.

A few things that will probably be helpfull.  Once you have entered a string
that was not found and the bar closes, FAYT will not re-open the bar but CTRL-F
will.  It looks like the toolbar is adding the new FAYT request to the original
"not found" string.
1a. Perform steps 1 -> 3 above.
2a. Type the following "/hello" (should re-open the find toolbar with the string
"hello" but doesn't)
3a. Press Ctrl-F

You will notice that the toolbar re-opens and the "find" field contains "zz/hello".


It is also interesting that if you delete "zz/hello" from the "find" field at
this point and close the toolbar, FAYT is still broken.

1b. Perform steps 1a -> 3a above
2b. Delete "zz/hello" from the "Find" field
3b. Close the toolbar using the close icon (frequently requires two clicks to
close at this point for some reason)
4b. Type the following "/hello" (should re-open the find toolbar with the string
"hello" but doesn't)
5b. Press Ctrl-F

You will notice that the toolbar re-opens and the "find" field contains "/hello".


Stranger still is the broken FAYT crosses tabs
1c. Perform steps 1b -> 5b above
2c. Close the toolbar using the close icon (frequently requires two clicks to
close at this point for some reason)
3c. Change to a different tab (click only the tab, do not click in the new window)
4c. Type the following "/hello" (should re-open the find toolbar in the new
window with the string "hello" but doesn't)
5c. Press Ctrl-F

You will notice that the toolbar re-opens and the "find" field contains
"/hello".  It appears the text field was cleared for the new tab, but FAYT still
does not work (If the field was not cleared, we would see "/hello/hello" at this
point)


At this point, since the original page has lost it's focus, if we go back to the
original page FAYT will work on this page.

I hope I've confused everyone enough!

Comment 1

[Peter van der Woude [:Peter6]]

*** This bug has been marked as a duplicate of 251891 ***

Comment 2

[Peter van der Woude [:Peter6]]

oops, didn't mean to do that

Comment 3

[Michael Clackler]

Marking "?" blocking aviary 1.0 since functionality is lost with no feedback.

Comment 4

[Michael Clackler]

Attachment: Test Case from Hoovers

I broke down the Hoovers page mentioned in this bug and found some code that
seems to "break" the find toolbar.  This testcase contains only the suspect
code and causes the find toolbar to break.

After opening this bug, I noticed the FAYT not only stops working, but neither
FAYT or CTRL-F find ANY text that is present.  Some javascript errors are also
present in the console.

Comment 5

[Michael Clackler]

Attachment: Test Case from episteme.arstechnica.com

Here's a second test case with different code from episteme.arstechnica.com
which breaks the find toolbar also.

Comment 6

[logan]

requesting 1.0rc1 as well. major bummer D:

Comment 7

[logan]

OS -> All

Comment 8

[Michael Clackler]

Fixed with the checkin for bug 253502

Comment 9

[logan]

Verified fixed on linux with today's build (yay!). Rather than closed, shouldn't
this be marked as a dupe of bug 253502?