252150 - shouldn't show deferred accounts in search dialog

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[nicolas chevreux]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2

When using the new Thunderbird builds with the global inbox, the list of folders
to seach in contains folders that do not exist.
For example, if all acount resolves to the "Local Folders" folder (i.e., if each
account does *not* have his own folder), each account is still listed, with his
"sent", "draft"... subfolders. And this is the case even when these folders
actually do not exist.

Reproducible: Always
Steps to Reproduce:
1. get the Thunderbird build with the global inbox
2. create 2 accounts
3. Tools -> Account Settings -> account1 - > Server settings -> advanced: click
on "Global inbox".
4. Tools -> Account Settings -> account1 - > Server settings -> advanced: click
on "Global inbox".
5. organize your folders so that you have only "Local folders", and no folder
for account1 and account2.
6. right click on a folder -> search messages
Actual Results:  
the drop down menu on top of the search windows displays "account1 - inbox,
drafts, sent...", "acount2 - inbox, drafts, sent...", "Local folders - inbox,
drafts, sent...", even though the account1 and account2 folders do not exists.

Expected Results:  
only existing folders should be displayed.

Comment 1

[Mark Janssen]

I can confim this.

It also shows up non-existing folders in the junk mail filter dialog.

Comment 2

[Mark Janssen]

Using version 0.8 (20040902) by the way.

Comment 3

[Scott MacGregor]

David, does it make sense for us to hide the hidden folders for folder menu
lists like the search dialog just like we do for the folder pane?

Comment 4

[David :Bienvenu]

yes, we should hide them. I can look into that. They do exist, and can contain
messages, but we'll not show them to you, so we should just pretend they don't
exist.

Comment 5

[Scott MacGregor]

cool, you might find:

msgFolderPickerOverlay.xul to be of help. I think all of our folder list widgets
get stuff from this overlay.

Comment 6

[David :Bienvenu]

I'm not sure about the junk mail dialog, however - those accounts do exist, and
we might use the per-account junk mail controls, but I think we use the local
folders junk controls. We don't show the deferred accounts as possible move
targets, which is correct.

Comment 7

[David :Bienvenu]

Attachment: proposed fix

why change xul when I can change c++? :-) We want deferred servers to not be
searchable in general...

Comment 8

[Scott MacGregor]

Comment on attachment 157836 [details] [diff] [review]
proposed fix

Let's put this on aviary too