Closed Bug 252423 Opened 20 years ago Closed 11 years ago

FinishHTMLSource() is no longer necessary

Categories

(SeaMonkey :: Composer, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.20

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file, 2 obsolete files)

Subsequent to the patch in bug 192557 (and the subsequent fix in bug 251686)
RebuildDocumentFromSource is unlikely to fail, and certainly not for the tests
that FinishHTMLSource uses. So I suggest that we eliminate FinishHTMLSource.
Attached patch Basic version (obsolete) — Splinter Review
Assignee: composer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attached patch Advanced version (obsolete) — Splinter Review
Product: Browser → Seamonkey
Attachment #153876 - Flags: review?(daniel)
This bug seems to be valid yet.

Neil, do you want to request review from someone else ?
Attachment #153878 - Flags: review?(brade)
Comment on attachment 153878 [details] [diff] [review]
Advanced version

Although I might have left the function FinishHTMLSource in place (having it make the call to  SetEditMode()), I'm fine with this change too.  r=brade
Attachment #153878 - Flags: review?(brade) → review+
Comment on attachment 153876 [details] [diff] [review]
Basic version

brade: if I'd known I'd have asked you for review on this one in the first place :-)
Attachment #153876 - Flags: superreview?(jag)
Attachment #153876 - Flags: review?(daniel)
Attachment #153876 - Flags: review?(brade)
Attachment #153878 - Flags: superreview+
Comment on attachment 153876 [details] [diff] [review]
Basic version

r=brade I don't care which one lands; thanks for this cleanup work!  :-)
Attachment #153876 - Flags: review?(brade) → review+
QA Contact: composer
Patch looks like still valid, get proper review, why it doesn't checked in?
Attachment #153876 - Attachment is obsolete: true
Attachment #153876 - Flags: superreview?(jag-mozilla)
Attachment #745834 - Flags: review?(neil)
Attachment #745834 - Flags: review?(neil) → review?(iann_bugzilla)
Changed reviewer per Ratty's comment
Attachment #745834 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Attachment #153878 - Attachment is obsolete: true
https://hg.mozilla.org/comm-central/rev/01e1e414fadd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.21
Target Milestone: seamonkey2.21 → seamonkey2.20
You need to log in before you can comment on or make changes to this bug.