Closed
Bug 252423
Opened 20 years ago
Closed 11 years ago
FinishHTMLSource() is no longer necessary
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.20
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file, 2 obsolete files)
8.36 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
Subsequent to the patch in bug 192557 (and the subsequent fix in bug 251686) RebuildDocumentFromSource is unlikely to fail, and certainly not for the tests that FinishHTMLSource uses. So I suggest that we eliminate FinishHTMLSource.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee: composer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•20 years ago
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
Assignee | ||
Updated•19 years ago
|
Attachment #153876 -
Flags: review?(daniel)
Comment 3•16 years ago
|
||
This bug seems to be valid yet. Neil, do you want to request review from someone else ?
Assignee | ||
Updated•16 years ago
|
Attachment #153878 -
Flags: review?(brade)
Comment 4•16 years ago
|
||
Comment on attachment 153878 [details] [diff] [review] Advanced version Although I might have left the function FinishHTMLSource in place (having it make the call to SetEditMode()), I'm fine with this change too. r=brade
Attachment #153878 -
Flags: review?(brade) → review+
Assignee | ||
Comment 5•16 years ago
|
||
Comment on attachment 153876 [details] [diff] [review] Basic version brade: if I'd known I'd have asked you for review on this one in the first place :-)
Attachment #153876 -
Flags: superreview?(jag)
Attachment #153876 -
Flags: review?(daniel)
Attachment #153876 -
Flags: review?(brade)
Updated•16 years ago
|
Attachment #153878 -
Flags: superreview+
Comment 6•16 years ago
|
||
Comment on attachment 153876 [details] [diff] [review] Basic version r=brade I don't care which one lands; thanks for this cleanup work! :-)
Attachment #153876 -
Flags: review?(brade) → review+
Updated•16 years ago
|
QA Contact: composer
Patch looks like still valid, get proper review, why it doesn't checked in?
Attachment #153876 -
Attachment is obsolete: true
Attachment #153876 -
Flags: superreview?(jag-mozilla)
Attachment #745834 -
Flags: review?(neil)
Attachment #745834 -
Flags: review?(neil) → review?(iann_bugzilla)
Attachment #745834 -
Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Updated•11 years ago
|
Attachment #153878 -
Attachment is obsolete: true
Comment 10•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/01e1e414fadd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.21
Updated•11 years ago
|
Target Milestone: seamonkey2.21 → seamonkey2.20
You need to log in
before you can comment on or make changes to this bug.
Description
•