Closed
Bug 252468
(autostretch)
Opened 21 years ago
Closed 20 years ago
Remove outdated autostretch attribute from the tree
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: sipaq, Assigned: sipaq)
References
()
Details
Attachments
(1 file, 2 obsolete files)
24.32 KB,
patch
|
neil
:
review+
sipaq
:
superreview+
|
Details | Diff | Splinter Review |
This is a followup bug for bug 94470.
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #153906 -
Flags: review?(neil.parkwaycc.co.uk)
![]() |
||
Comment 2•21 years ago
|
||
rs=me once this has sr=neil
Comment 3•21 years ago
|
||
Comment on attachment 153906 [details] [diff] [review]
Patch v1
As well as the cases where elements have no children there are a couple of
cases where you don't need autostretch or align: you need
*) an hbox inside a vbox, or vice versa
*) the inner box must not have flex
*) an inner vbox may only have one child, except for <spacer>
*) an inner hbox must have only one child tag, and/or <spacer>
But don't change any you aren't happy with.
>- box.setAttribute("autostretch", "never");
You don't seem to replace this for some reason...
>- <row autostretch="never" valign="middle">
>+ <row align="center" valign="middle">
While you're doing cleanup, valign="middle" was the default (with
autostretch="never"); align="center" covers both..
Attachment #153906 -
Flags: review?(neil.parkwaycc.co.uk) → review-
Assignee | ||
Comment 4•20 years ago
|
||
Patch addressing review comments
Attachment #153906 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #154588 -
Flags: review?(neil.parkwaycc.co.uk)
Updated•20 years ago
|
Attachment #154588 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Assignee | ||
Comment 5•20 years ago
|
||
Comment on attachment 154588 [details] [diff] [review]
Patch v2
rs=bz, since this has been review+'ed by Neil (see comment 2).
Attachment #154588 -
Flags: superreview+
Assignee | ||
Updated•20 years ago
|
Alias: autostretch
Comment 6•20 years ago
|
||
checked in. please mark fixed if it is.
Assignee | ||
Updated•20 years ago
|
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•20 years ago
|
||
Seems like I overlooked one more instance of autostretch in the code.
See
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/resources/content/mailComposeBindings.xml#9
Neil, can we just replace this with align="center" again or can this be removed?
Comment 8•20 years ago
|
||
(In reply to comment #7)
>can we just replace this with align="center" again or can this be removed?
It can be removed ;-) let me dig out my patch for that...
Comment 9•20 years ago
|
||
Comment 10•20 years ago
|
||
Comment on attachment 155574 [details] [diff] [review]
Remove mailComposeBindings.xml
Similar changes will apply to mail/, do you want me to write a combined patch?
Attachment #155574 -
Flags: review?(mscott)
Assignee | ||
Comment 11•20 years ago
|
||
Neil, I would never have dared to completely eliminate the whole file, but I
like your change :-)
Shouldn't you also ask for sr or is mailnews strongly owned now and a single
review is sufficient?
Comment 12•20 years ago
|
||
Comment on attachment 155574 [details] [diff] [review]
Remove mailComposeBindings.xml
Silly me, this is bug 244886.
Attachment #155574 -
Attachment is obsolete: true
Attachment #155574 -
Flags: review?(mscott)
Comment 14•20 years ago
|
||
Relanding toolkit part of patch v2 following landing of aviary branch
Keywords: aviary-landing
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•