Closed Bug 252468 (autostretch) Opened 21 years ago Closed 20 years ago

Remove outdated autostretch attribute from the tree

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sipaq, Assigned: sipaq)

References

()

Details

Attachments

(1 file, 2 obsolete files)

This is a followup bug for bug 94470.
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #153906 - Flags: review?(neil.parkwaycc.co.uk)
rs=me once this has sr=neil
Comment on attachment 153906 [details] [diff] [review] Patch v1 As well as the cases where elements have no children there are a couple of cases where you don't need autostretch or align: you need *) an hbox inside a vbox, or vice versa *) the inner box must not have flex *) an inner vbox may only have one child, except for <spacer> *) an inner hbox must have only one child tag, and/or <spacer> But don't change any you aren't happy with. >- box.setAttribute("autostretch", "never"); You don't seem to replace this for some reason... >- <row autostretch="never" valign="middle"> >+ <row align="center" valign="middle"> While you're doing cleanup, valign="middle" was the default (with autostretch="never"); align="center" covers both..
Attachment #153906 - Flags: review?(neil.parkwaycc.co.uk) → review-
Attached patch Patch v2Splinter Review
Patch addressing review comments
Attachment #153906 - Attachment is obsolete: true
Attachment #154588 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #154588 - Flags: review?(neil.parkwaycc.co.uk) → review+
Comment on attachment 154588 [details] [diff] [review] Patch v2 rs=bz, since this has been review+'ed by Neil (see comment 2).
Attachment #154588 - Flags: superreview+
Alias: autostretch
checked in. please mark fixed if it is.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Seems like I overlooked one more instance of autostretch in the code. See http://lxr.mozilla.org/seamonkey/source/mailnews/compose/resources/content/mailComposeBindings.xml#9 Neil, can we just replace this with align="center" again or can this be removed?
(In reply to comment #7) >can we just replace this with align="center" again or can this be removed? It can be removed ;-) let me dig out my patch for that...
Comment on attachment 155574 [details] [diff] [review] Remove mailComposeBindings.xml Similar changes will apply to mail/, do you want me to write a combined patch?
Attachment #155574 - Flags: review?(mscott)
Neil, I would never have dared to completely eliminate the whole file, but I like your change :-) Shouldn't you also ask for sr or is mailnews strongly owned now and a single review is sufficient?
Comment on attachment 155574 [details] [diff] [review] Remove mailComposeBindings.xml Silly me, this is bug 244886.
Attachment #155574 - Attachment is obsolete: true
Attachment #155574 - Flags: review?(mscott)
looks like the firefox part needs relanding
Keywords: aviary-landing
Relanding toolkit part of patch v2 following landing of aviary branch
Keywords: aviary-landing
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: