25275 - allow url column to be shown in list of bugs

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement, P3)

Description

[Jason Kersey]

I noticed that you can customize what columns are shown when you have a list of 
bugs, and I was curious if the URL of the bug could be made into a column here?  
It would be helpful when trying to find a specific bug, or set of bugs, based on 
urls.

Comment 1

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 2

[Dave Miller [:justdave]]

*** Bug 51849 has been marked as a duplicate of this bug. ***

Comment 3

[Matthew Tuck [:CodeMachine]]

3.0 Nomination: New modular design should basically let you choose any field
AFAICT.

Comment 4

[Dave Miller [:justdave]]

Moving to real milestones...

Comment 5

[Hixie (not reading bugmail)]

Taking all Bugzilla 3.0 bugs -- congratulations to MattyT for the triage, it
really was spot on. Note: I may end up pushing some of these bugs back to 3.2,
we'll see. However, I believe all these bugs should just fall out of the 
redesign. Let's hope I'm right!

(Note: I'm also resetting the priority field to "---" so that I can retriage any
that I consider important or likely to be dropped.)

Comment 6

[Dave Miller [:justdave]]

The Bugzilla 3 component is going away.  We're going to depend on the Milestones 
for this.  At the time this component was created, we didn't have milestones for 
Bugzilla.

Comment 7

[Andreas Franke (gone)]

-> Bugzilla product, Buglist component.

Leaving this bug for implementation in Bugzilla 3.0, and Bug 75071 for 2.16.
That one has a better reason why this is useful, and a better target milestone.

Comment 8

[Hixie (not reading bugmail)]

Bailing on Bugzilla 3.0 due to too many other commitments.

Comment 9

[Frédéric Buclin]

*** Bug 75071 has been marked as a duplicate of this bug. ***

Comment 10

[Peter Florijn]

I'm not an expert in Perl but would like to try to make a patch for this. 
But I think I need some coaching as I have never created a patch for 
Bugzilla.

As a first result I found out in order to be able to show the URL column I 
have to change

Patch colchange.cgi
- add "bug_file_loc" to @masterlist

Patch buglist.cgi

add
DefineColumn("url       "        , "bugs.bug_file_loc"          , "URL 
"       );

I can now select the URL column in change columns, but it is still not 
showing up.

Any suggestions ?

Peter

Comment 11

[Frédéric Buclin]

We are freezing the code for 3.0 in two weeks and we don't expect this bug to be fixed on time.

Comment 13

[Max Kanat-Alexander]

This is basically WONTFIX in favor of bug 372966.

Comment 14

[Frédéric Buclin]

Not a dupe, and would be fixed by bug 372966.

Comment 16

[Gervase Markham [:gerv]]

I don't know if this was a one-line change back in 2000, but it certainly is now. See bug 520433 for the details.

Gerv

Comment 17

[Gervase Markham [:gerv]]

Attachment: Patch v.1

OK, we store this in the DB, so 5 lines.

Gerv

Comment 18

[Gervase Markham [:gerv]]

mkanat: LpSolit thinks it's not necessary to update Install/DB.pm. Is he right?

Gerv

Comment 19

[Max Kanat-Alexander]

Comment on attachment 404507 [details] [diff] [review]
Patch v.1

>Index: Bugzilla/Install/DB.pm
>+    # Bug 25275 - add URLs to bug lists
>+    $dbh->do("UPDATE fielddefs SET buglist = 1
>+              WHERE name = 'bug_file_loc'");

  That's not necessary, you only need to set it in Bugzilla/Field.pm, which will do the updating automatically.

  Otherwise this looks fine.

Comment 20

[Max Kanat-Alexander]

Might as well put this in 3.6. Who knows, the URL field could be gone by 3.8. :-)

Comment 21

[Frédéric Buclin]

Comment on attachment 404507 [details] [diff] [review]
Patch v.1

You need to set a max length for the URL column, else it can easily be as large as your window, which is undesired.

Comment 22

[Gervase Markham [:gerv]]

Max/LpSolit: what value would be appropriate for the max length of the URL column? 30 characters? 40?

Gerv

Comment 23

[Max Kanat-Alexander]

  I think 32 characters would be reasonable, just as a sort of arbitrary number off the top of my head.

  Making the column into a hyperlink to the URL (unless it's a data: or javascript: URL) would also be neat.

Comment 24

[Gervase Markham [:gerv]]

Attachment: Patch v.2

I've removed the code you said was unnecessary, and added a length limit. (30 chars, for consistency with other fields in the file. If we used 32 and lots of others were 30, people would wonder why it was different.)

Autolinkifying it can be a separate enhancement bug :-)

Gerv

Comment 25

[Eric Krock]

To confirm: the length limit you're discussing is for visual DISPLAY of the URL, not a maximum length of the stored URL itself, right? Unfortunately, it's common for URLs to be very long these days, so the database should be able to store a URL of whatever the maximum supported length for a URL is according to the relevant RFC. (Is there one? Not sure how maximum length squares up with long URL parameter lists.) Since the URL field is in use in Bugzilla (if not showable in query results), presumably this is already taken care of.

I completely understand that for purposes of display, you don't want to be creating a text field that's so wide that it causes the window to expand, for example.

Sorry if this is all obvious. Thanks Gerv!

Comment 26

[Gervase Markham [:gerv]]

Eric: Long time no see! What are you up to these days?

Yes, the length limit is solely for display in buglists, not for the field itself. The DB field is an SQL MEDIUMTEXT which, in MySQL at least, has a max length of 16777215 characters :-)
http://www.sqlinfo.net/mysql/mysql_data_types.php

(You know, we could have got away with a TEXT - that maxes out at 65535.)

Gerv

Comment 27

[Frédéric Buclin]

Comment on attachment 430310 [details] [diff] [review]
Patch v.2

>Index: colchange.cgi
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v
>retrieving revision 1.72
>diff -5 -p -u -r1.72 colchange.cgi
>--- colchange.cgi	15 Feb 2010 23:31:50 -0000	1.72
>+++ colchange.cgi	4 Mar 2010 15:36:31 -0000
>@@ -66,10 +66,11 @@ if (Bugzilla->params->{"useqacontact"}) 
>     push(@masterlist, "qa_contact_realname");
> }
> if (Bugzilla->params->{"usestatuswhiteboard"}) {
>     push(@masterlist, "status_whiteboard");
> }
>+push(@masterlist, "bug_file_loc");
> if (Bugzilla::Keyword->any_exist) {
>     push(@masterlist, "keywords");
> }
> if (Bugzilla->has_flags) {
>     push(@masterlist, "flagtypes.name");
>Index: template/en/default/list/table.html.tmpl

This change doesn't apply to 3.8 anymore and is now useless as colchange.cgi knows which columns to list, see bug 545587. But it's still relevant to 3.6. r=LpSolit

Please file a separate bug to linkify URLs in buglists.

Comment 28

[Frédéric Buclin]

IMO, it's still an enhancement, and we are post-RC1.

Comment 29

[Max Kanat-Alexander]

  Okay, that's fine with me, then.

Comment 30

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Field.pm
modified template/en/default/list/table.html.tmpl
Committed revision 7094.

Comment 31

[Max Kanat-Alexander]

Added to the release notes in bug 604256.