252944 - Click in browser on link to ics file causes QueryInterface error (1.7/1.8 uriloader nsIContentHandler compatibility)

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2, 2004062218-cal

(This was reported earlier but I can't seem to find the bug.)



Reproducible: Always
Steps to Reproduce:
Click on any holiday file on the holidays page (see URL) to get the following
error in the JavaScript console:
Actual Results:  


Error: [Exception... "Component returned failure code: 0x80004002
(NS_NOINTERFACE) [nsISupports.QueryInterface]"  nsresult: "0x80004002
(NS_NOINTERFACE)"  location: "JS frame ::
file:///C:/Program%20Files/Mozilla%20Firefox/components/calendarService.js ::
anonymous :: line 116"  data: no]
Source File:
file:///C:/Program%20Files/Mozilla%20Firefox/components/calendarService.js
Line: 116

Expected Results:  
Subscribe dialog with clicked url filled in.

Workaround:

Right click on link.
Copy Link Location
In Calendar, menu Tools | Subscribe to remote calendar
Paste link url into Location field
Copy filename to into Name field

Comment 1

[gekacheka]

Attachment: calendarService.js patch: allow 3 or 4 parameters (1.7/1.8 compatibility)

Problem appears to be caused by this change
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/calendar/resources/content&command=DIFF_FRAMESET&file=calendarService.js&rev1=1.9&rev2=1.10&root=/cvsroot

which was for bug 239604.

Basically, the aCommand parameter was removed for Moz1.8, so it works in Moz1.8
but Moz1.7, FF, and TB all called queryInterface on the wrong parameter.

The fix is to add compatibility code that checks to see if 3 or 4 parameters
are recieved, and uses the correct parameter.

Comment 2

[gekacheka]

Patch tested on Moz1.7, Moz1.8a2, FF0.9.2.

Comment 3

[Mostafa Hosseini]

Checked in. Thanks

Comment 4

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!