252974 - Wrong winstripe icons in Help

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Kevin Hjelden]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040723 Firefox/0.9.1+ (MOOX-AV)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040723 Firefox/0.9.1+ (MOOX-AV)

Go to Help->Help Contents and look at the forward/back buttons presented. They
match with the 0.9.0 Winstripe version, but not the 0.9.1+ winstripe version

Reproducible: Always
Steps to Reproduce:
1. Go to Help->Help Contents
2.
3.

Actual Results:  
Icons are the old "triangle" forward/back buttons

Expected Results:  
The "arrow" forward/back buttons

Comment 1

[Kevin Hjelden]

Attachment: renames help-xxx-button, (forwardback/home) -> xxx-button

applies to firefox/chrome/help/content/help/help.xul

Comment 2

[R.J. Keller]

Bug confirmed and accepting.

Not sure why we would want to rename the IDs of the help buttons. I got a much
better alternative.

Comment 3

[gumpish]

This is also true of the screenshot on the Firefox webpage:

http://www.mozilla.org/products/firefox/

Comment 4

[R.J. Keller]

Attachment: Patch

Comment 5

[Jeff Walden (gone starting June 8)]

(In reply to comment #3)

That's a different bug that would be filed under Firefox->Web Site.  If it's not
already filed by someone else, that's the place for it.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 154288 [details] [diff] [review]
Patch

I'll check this tonight or tomorrow, I seem to remember this doing weird things
with button/text alignment, as part of a different patch maybe?

Comment 7

[R.J. Keller]

(In reply to comment #6)
> (From update of attachment 154288 [details] [diff] [review])
> I'll check this tonight or tomorrow, I seem to remember this doing weird things
> with button/text alignment, as part of a different patch maybe?
> 

It's a different patch that I tested out.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 154288 [details] [diff] [review]
Patch

r=[e-mail]

Comment 9

[Mike Connor [:mconnor]]

I thought Help didn't need approval-aviary, per ben's npm.seamonkey post

Comment 10

[Jeff Walden [:Waldo]]

(In reply to comment #9)
> I thought Help didn't need approval-aviary, per ben's npm.seamonkey post

Heh, I didn't know Ben wrote that.  In that case bug 237839 can probably also be
checked in, as it has to fit at least one of the categories.

Comment 11

[R.J. Keller]

(In reply to comment #8)
> (From update of attachment 154288 [details] [diff] [review])
> r=[e-mail]
> 

only Documentation, not XUL and JS changes.

Comment 12

[R.J. Keller]

(In reply to comment #9)
> I thought Help didn't need approval-aviary, per ben's npm.seamonkey post

only Documentation, not XUL and JS changes.

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 154288 [details] [diff] [review]
Patch

a=[e-mail]

Comment 14

[R.J. Keller]

Fix checked in.