253068 - Help Doc on Cookies needs to be updated

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Steffen Wilberg]

"Enable Cookies" has been renamed to "Allow sites to set cookies".

Instead of the "Accept cookies normally", "Accept for current session only" and
"Ask for each cookie" radiobuttons, there's now a "Keep Cookies" menulist,
containing the items "until they expire", "until I close Firefox", and "ask me
every time".

Comment 1

[Steffen Wilberg]

This applies both to Options->Privacy Options->Cookies and to Managing Cookies.

Comment 2

[[e-mail]]

we probably need help/explanations on how the permission manager works, too.

Comment 3

[R.J. Keller]

Accepting. I thought I fixed this but must've missed some of them.

Comment 4

[R.J. Keller]

Steffen, not sure why you took these flags off. This should block 1.0RC 1
because that is the localization freeze.

Comment 5

[Steffen Wilberg]

I thought it was sufficient to request them on the tracking bug.

Comment 6

[R.J. Keller]

(In reply to comment #2)
> we probably need help/explanations on how the permission manager works, too.

That's already in there.

OK, this bug should be fixed.

Comment 7

[Steffen Wilberg]

Huh? In cookies.xhtml, there are now two headings and two descriptions for "for
the originiating Web site only". And there is no "Ask for each cookie checkbox"
anymore, that's now the "ask me every time" option. (Besides, I strongly suggest
to use the "until I close Firefox" option and whitelist cookies you want to
store permanently).

And pref.xhtml needs to be updated as well.

Comment 8

[R.J. Keller]

Attachment: Patch

well, tree is closed so I'll post my changes and if there are problems, just
tell me.

Comment 9

[R.J. Keller]

Comment on attachment 154507 [details] [diff] [review]
Patch

steffen, tell me if I covered everything. I'm pretty sure I did, but would like
to make sure.

Comment 10

[Steffen Wilberg]

Comment on attachment 154507 [details] [diff] [review]
Patch

You covered everything in cookies.xhtml as far as I can see, but you still miss
prefs.xhtml:
http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US
/prefs.xhtml#221

Comment 11

[Steffen Wilberg]

http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US/prefs.xhtml#221

Comment 12

[R.J. Keller]

Comment on attachment 154507 [details] [diff] [review]
Patch

yeah, I'll get to that later, but is cookies.xhtml OK?

Comment 13

[Mike Connor [:mconnor]]

<+firebot> [e-mail] has requested review from the wind on a patch on bug
253068.

Comment 14

[Steffen Wilberg]

Comment on attachment 154507 [details] [diff] [review]
Patch

cookies.xhtml is fine.

Comment 15

[Francesco Lodolo [:flod]]

I've just downloaded latest-trunk and watched at this file.
Is it just my opinion or the two images at the end of the page (cookie list e
site list) are inverted?

Comment 16

[R.J. Keller]

Attachment: Patch for prefs.xhtml

Comment 17

[R.J. Keller]

Comment on attachment 154592 [details] [diff] [review]
Patch for prefs.xhtml

Steffen, can you review this? I decided to just link to cookies.xhtml instead
of repeating the prefs information again.

Comment 18

[R.J. Keller]

Checked in cookies.xhtml part.

Comment 19

[Steffen Wilberg]

Comment on attachment 154592 [details] [diff] [review]
Patch for prefs.xhtml

Sure.

Comment 20

[Steffen Wilberg]

I didn't notice the button label changed from "Stored Cookies" to "View
Cookies". Can you change that in cookies.xhtml as well? "Stored Cookies dialog"
is still correct, but the button label needs to be changed:
http://lxr.mozilla.org/aviarybranch/source/browser/components/help/locale/en-US/cookies.xhtml#159

Comment 21

[R.J. Keller]

OK, fix checked in.

Comment 22

[Steffen Wilberg]

I just checked in the change I mentioned in comment 20 (Stored Cookies button
has been renamed to View Cookies).

Comment 23

[Steffen Wilberg]

Comment on attachment 154507 [details] [diff] [review]
Patch

>Index: components/help/locale/en-US/cookies.xhtml
>+  <li>Select the <em>ask me every time</em> option from the <span class="menuPath">
>+    Keep Cookies</span> combo box.</li>
Yes, I r'ed it, but why has "Keep Cookies" class="menuPath"? I can't find
anything other than menuitems having this class. And while we're at it, how
about "drop-down list" instead of "combo box"? We're using the former term in
prefs.xhtml and using_firebird.xhtml. And what's a combo box anyway? :)