253288 - At secure sites, the Lock icon is missing from the status bar

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Tracy Walker [:tracy]]

Seen on windows Firefox branch build 0.9+ 2004-07-27-08-0.9

-Go to https://sourceforge.net

tested results: The domain name of the site appears in the staus bar but the
Lock icon is missing.  Double clicking does open the Page Info with security tab
selected as expected.  We're just missing the lock icon.

expected results: The domain name and the Lock icon both appear in the status bar.  

note: This works as expected with the same time stamped build on Linux.

Comment 1

[Jesse Ruderman]

Caused by the checkin for bug 245406.

Comment 2

[Markus Lindström]

Attachment: Domain in status bar overlaps its area, or appears truncated.

Additionally, the domain seems to overlap the status bar area dedicated to
security, and at times it can also be truncated. See attachment.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040727
Firefox/0.9.1+

Comment 3

[Steffen Wilberg]

Attachment: fix the button width on Winstripe

This is the same patch I already attached to bug 245406. Moving it to this bug
for clarity's sake.

Comment 4

[Steffen Wilberg]

Comment on attachment 154490 [details] [diff] [review]
fix the button width on Winstripe

The button should be a bit wider than 20px when displaying the host name.

Remaining glitch:
On sites where a broken lock is displayed, like https://www.dab-bank.com/, the
icon is moved to the right. If there's no width specified, the icon position is
correct, but the button is extended to the left, i.e. a blank space is
displayed left of the icon.

Comments by Gerv:
I also see the blank space to the left of the icon; this seems to be caused by
the left and right margins on the empty label. I'm not quite sure why they are
appearing when the icon appears but not when it's not...
We _could_ fix the label margins problem by styling it to have zero margins
when
it's empty, but I'm not sure that's the right fix; this may be symptomatic of
some deeper misunderstanding/mistake.

Comment 5

[Richard Klein]

Why not change the width attribute to min-width instead of adding a bunch of
other rules?  I've done this in the classic jar and it fixed it for me. 
page-report-button, page-theme-button, and livemark-button rules could use the
same setting.

Comment 6

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

*** Bug 253345 has been marked as a duplicate of this bug. ***

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 154490 [details] [diff] [review]
fix the button width on Winstripe

r/a=[e-mail]

Comment 8

[Gervase Markham [:gerv]]

Steffen: I'm assuming you'll be checking this in...

The last thing to do then is to fix the problem with the box widening when
there's an icon but no text (in the broken security case, for example). This is
caused by the default margins on the label. 

We need a CSS rule which styles the label when it's _missing_ a "value"
attribute (either that, or we need to change the code so it always has a value
attribute, but it's blank when it's not being used). I'm not sure I know how to
write such a rule in the first case; I've tried using the :not pseudoclass but I
can't get it to work.

Gerv

Comment 9

[Steffen Wilberg]

Attachment: also fix the broken lock icon

This fixes the problem with the hidden label shifting the broken icon to the
right:
   +/* XXXsw a label without a value still has margins, so hide it */
   +#security-button > label:not([value]) {
   +  display: none;
   +}

(I also tried to set that as a general rule in xul.css, but it hides all sorts
of labels in the Options dialog (especially in Web Features) which have
"xbl:text=label" instead of "label".)

With that fixed, we can use min-width. I had to play a lot with paddings to
make that behave, i.e. still 20px wide when the broken lock is displayed, and
showing the icon at the same position, whether "broken" or not.

I didn't touch Pinstripe since that does |display:none| on the buttons when no
icon is displayed.

Comment 10

[Steffen Wilberg]

Comment on attachment 154553 [details] [diff] [review]
also fix the broken lock icon

better patch, please have a look.

Comment 11

[Gervase Markham [:gerv]]

Nice one :-) That's what I couldn't work out. Go to it. I'm away for the next
nine days; thank you so much for clearing up after me :-)

Gerv

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 154553 [details] [diff] [review]
also fix the broken lock icon

> #page-report-button[blocked] {
>   list-style-image: url("chrome://browser/skin/Info.png");
>-  padding: 0px 3px 0px 3px; 
> }

... etc ...

what does this have to do with fixing the lock icon? What's the visual effect?

Comment 13

[Tracy Walker [:tracy]]

changed the test URL to verisign.com.  Sourceforge has been serving up mixed
content. 

Comment 14

[Steffen Wilberg]

> > #page-report-button[blocked] {
> >   list-style-image: url("chrome://browser/skin/Info.png");
> >-  padding: 0px 3px 0px 3px; 
> > }
> 
> ... etc ...
> 
> what does this have to do with fixing the lock icon?
I'm cleaning up the padding. Right now, we have statusbarpanel { padding: 0 4px; }
http://lxr.mozilla.org/aviarybranch/source/toolkit/themes/winstripe/global/global.css#127

Without these 4px left and right, the buttons have a width of 18px. But they're
set to 20px in browser.css. So the 4px in global.css are too much, as well as
the 3px in in some places in browser.css. I set the padding to 1px left and
right in global.css, so that I can use min-width for the lock icon and still get
a width of 20px if the broken lock is displayed.

What's the visual effect?
None :) The 3px padding is not visible because the button width is set to 20px
anyway.

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 154553 [details] [diff] [review]
also fix the broken lock icon

Please don't request approval until you've received necessary reviews. Thanks.

Comment 16

[Bill Gianopoulos [:WG9s]]

I thought Ben said Theme fixes did not need approval-aviary for checkin anyway.

Comment 17

[Bill Gianopoulos [:WG9s]]

What' up with this bug?  we have a patch.  It's a security issue.  Why isn't it
checked in yet?

Comment 18

[Michael Lefevre]

Because, like a bunch of other stuff, it's awaiting review. It's marked as a
blocker for 1.0PR, so it should get looked at by then. Have some patience...

Comment 19

[Gervase Markham [:gerv]]

These are indeed theme fixes; contact the maintainer of the themes to get
review, then check in ASAP :-)

Gerv

Comment 20

[Steffen Wilberg]

Comment on attachment 154553 [details] [diff] [review]
also fix the broken lock icon

Kevin, can you jump in for Ben and review this, please? We need to fix this
before 1.0PR.

Comment 21

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 154553 [details] [diff] [review]
also fix the broken lock icon

steffen, just go ahead and land this now... r+a=[e-mail]

Comment 22

[Steffen Wilberg]

Checked into the branch 08/09/2004 14:07.
The trunk doesn't have the restyled notification area yet.

Comment 23

[Tracy Walker [:tracy]]

windows FF0.9+ build 2004-08-10-08-0.9 is fixed.

Comment 24

[Tom Graham]

Attachment: Still doesn't appear to be fixed.

Comment 25

[Tom Graham]

Appologies... crossed wires.