253443 - no spell checker included in typical install for Linux seamonkey

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2004072808-trunk (seamonkey) bits on linux fedora core 1. couldn't
find an exisiting bug on this, so pls dup if needed. (would this be related in
anyway to bug 240600?)

1. open composer window
2. type in some misspelled words
3. look for spell checker

results: I couldn't find a spell checker in the Edit menu, Tools menu or the
compose toolbar.

this is not a problem with seamonkey trunk bits on Mac OS X or Windows.

Comment 1

[sairuh (rarely reading bugmail)]

about:buildconfig says "--enable-extensions=default,irc,tasks,negotiateauth":
doesn't that mean the spellchecker should be built? then again, when I checked
the components directory, I didn't see a file describing the spell checker...

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

http://lxr.mozilla.org/seamonkey/source/configure.in#3801 lists spellcheck as
part  of the default extensions.
It works on my self-made gtk2 build
(bug 240600 is unrelated. nothing of that got checked in yet)

Comment 3

[sairuh (rarely reading bugmail)]

okay, I went back to the earliest trunk build I could find, from 2004060107, and
the spellchecker is still missing. could this be a build issue for release builds?

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Works for me in both latest trunk, and 1.8a2,both from ftp.mozilla.org. linux.

Comment 5

[sairuh (rarely reading bugmail)]

hm, fwiw, I'm using a "typical" installation --could that choice prevent the
spellchecker from installing (as opposed to a custom install where the
components are specifically chosen)?

Comment 6

[sairuh (rarely reading bugmail)]

just spoke to Asa, and that's indeed the case: spellchecker isn't part of the
typical (default) installation on linux, and it should be changed. so, am
morphing this bug (no longer a smoketest issue).

Comment 7

[sairuh (rarely reading bugmail)]

also see this with a typical (default) installation using the 1.7 bits
(2004072810-1.7).

Comment 8

[sairuh (rarely reading bugmail)]

sigh, forgot to nominate till now. if too late for 1.8a4, then perhaps the next
milestone...

Comment 9

[Andrew Schultz]

Attachment: patch

add spellchecker.
this also includes a comment I forgot for bug 157459 comment 20

Comment 10

[Andrew Schultz]

me

Comment 11

[Benjamin Smedberg]

Comment on attachment 159935 [details] [diff] [review]
patch

The English spellchecker dictionary is MPL-compatible, right?

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 159935 [details] [diff] [review]
patch

Whether it is or isn't MPL-compatible, it's already shipping in the other setup
types. I'm pretty sure it was checked out before adding it to the build, but if
you have concerns check w/mkaply. Not in this bug, though.

sr=dveditz

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 159935 [details] [diff] [review]
patch

a=asa for 1.8a4 checkin.

Comment 14

[Kenneth Herron]

Checking in config.it;
/cvsroot/mozilla/xpinstall/packager/unix/config.it,v  <--  config.it
new revision: 1.29; previous revision: 1.28
done

Comment 15

[Andrew Schultz]

fixed

Comment 16

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2004092709-trunk (gtk1, full installer, "typical" installation
choice). thanks, Andrew!