25360 - need to check channel for errors after NS_OpenURI().

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[pnunn]

make changes so channel is checked for error after NS_OpenURI()
for images.
-pn 

notes from email conversion with valeski:
  P:Let's say someone requests a nonexistant image file. 
    Shouldn't I get back an error from NS_OpenURI() for 
    that file?

  V:None of the NS_OpenURI() forms will return failure if the file DNE. 
   They are simply util functions that give you a channel that you can
   read/write on (or kick the "load" off). Regardless, we are 
   currently pushing the 404 html out as the URL data and not 
   indicating error. To handle this case you can get teh 
   Response code from the channel and error
   out if it's 404.

Comment 1

[pnunn]

Neeti is following up on this one.
Reassigning.
-p

Comment 2

[neeti]

Checked in a fix.

Comment 3

[Eli Goldberg]

Pam, would you like to verify this, or shall I rubber-stamp without inspection? 
Thanks!

Comment 4

[pnunn]

I will testify.

Comment 5

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/540fee70b661
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25360: Selectively update addresses preference only when needed.