254195 - [has patch] Find Toolbar's highlight function does not work with frames

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Thomas Kaschwig]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.1+

The highlight function of the Find Toolbar does not work on frame based documents.

Reproducible: Always
Steps to Reproduce:
1. Open a website that uses frames
2. Enter a search phrase into the Find Toolbar
3. click "Highlight"

Actual Results:  
None of the occurrences of the search phrase is highlighted in any frame.

Expected Results:  
The search phrase should be highlighted, as with not frame based documents.

Comment 1

[Michael Clackler]

The patch to fix this is included in the patch to fix bug 250282.  I noticed the
problem with frames in the code while fixing bug 250282 and could not find it
reported, so I just added it in with the patch for 250282.

Basically, the variables were in the wrong order when calling the function for
highlighting into frames.
It is:
    highlightDoc(word, color, win.frames[i]);

It should be:
    highlightDoc(color, word, win.frames[i]);

Comment 2

[Thomas Kaschwig]

Bug still exists in Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2)
Gecko/20040816. Requesting `blocking-aviary1.0'.

Comment 3

[Michael Clackler]

Attachment: patch to fix

Since the patch for bug 250282 needs some work, I "pulled out" the one-line
code change from that patch that fixes this bug so this problem can be fixed
asap.

Comment 4

[chris hofmann]

blake, can you review?  seems like a simple and good change to pick up.

Comment 5

[Blake Ross]

I already fixed this in another checkin. It's irrelevant anyways, since
highlight is going away.