Closed Bug 254517 Opened 21 years ago Closed 21 years ago

not found indicated with no find string

Categories

(Toolkit :: Find Toolbar, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

VERIFIED DUPLICATE of bug 256656

People

(Reporter: mikeclackler, Assigned: bugzilla)

Details

(Whiteboard: no l10n impact)

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040802 Firefox/0.9.1+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040802 Firefox/0.9.1+ If the previous find in one tab results in a "not found" situation, a find started in a second tab initiates in a "not found" state with no find string entered. Reproducible: Always Steps to Reproduce: 1. Open two tabs 2. In the first tab, initiate a find which results in "not found" then close the find bar 3. Change to the second tab 4. Initiate a find with ctrl-F or / Actual Results: Find bar in second tab is opened with no text in the find field and toolbar is indicating a "not found" state. Expected Results: Find bar in second tab is opened with no text with no find status since no has been requested. This happens with all status indications( not found and wrapped top/bottom) Looking at the code, once the find state is set it is not cleared until another find is completed.
Attached patch patch to fixSplinter Review
Corrects problem by clearing status state when toolbar is opened if find field is empty, and updating status state if find field is not empty.
Attachment #155397 - Flags: review?(firefox)
requesting blocking-aviary1.0 or PR since patch exists
Flags: blocking-aviary1.0PR?
Flags: blocking-aviary1.0?
Whiteboard: no l10n impact
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #155397 - Flags: review?(firefox)
*** This bug has been marked as a duplicate of 256656 ***
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → VERIFIED
Flags: blocking-aviary1.0PR?
Flags: blocking-aviary1.0?
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: