256656 - Find toolbar still says "Phrase not found" when starting a new find

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Thomas Rutter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040823 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040823 Firefox/0.9.1+

When starting a new find by pressing '/', the find toolbar is still red from the
last find it did where it didn't find results.

Reproducible: Always
Steps to Reproduce:
1. Press '/' to open find toolbar
2. Search for something that isn't on the page
3. Wait until the toolbar goes away or make it go away by clicking in the page
4. Press '/' to open find toolbar

Actual Results:  
Text field in toolbar is empty and coloured red.

Expected Results:  
Text field should be empty and coloured white.

IMO the text field should always be white when it is empty, and only turn a
colour when there is text in there.

Using Aviary branch 20040823 build.

Comment 1

[Jesse Ruderman]

Blake checked in a patch yesterday that sounded like it was intended to fix this
bug.

WFM with today's build.  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.7.2) Gecko/20040825 Firefox/0.9.1+

Comment 2

[Thomas Rutter]

Red colour is fixed, but "Phrase not found" text remains.  Bug re-opened.

Comment 3

[Fareed Rizkalla]

i think resetting values is a solution

Comment 4

[Michael Clackler]

Attachment: patch to fix new not found string problems

This patch fixes the "new problem" by clearing the statustext value.

The patch also moves the clearing of the values from on a find bar close to
just before a find bar open.  With the recent checkin that allows the status to
be changed on a hidden findbar (w/ ctrl-G), there is a possibility that a
"wrap" status could be displayed when a findbar is opened with an empty field
if the last find on a different tab was with ctrl-g and ended on a wrap. (since
the find bar doesn't open on "wraps" with ctrl-g it can never close, and
therefore doesn't clear the status values)  It makes more sense to me to clear
the settings just before the bar opens to ensure that, no matter what, the find
bar opens with no status indications.

Finally, since the status is being removed when the find bar opens (or even
before when it closed), if a previous find string was not found before the
findbar closed and the findbar is re-opened with ctrl-F, the string will still
be in the findbar but there will be no "not found status".  This patch puts in
place an automatic find when the find bar is opened with ctrl-f if the text box
is not empty to ensure the find status for the displayed string is correct when
the bar opens.

Comment 5

[Michael Clackler]

*** Bug 254517 has been marked as a duplicate of this bug. ***

Comment 6

[chris hofmann]

maybe we will be able take this if it gets reviews.  renominate if it gets a
review.  thanks

Comment 7

[Raanan Barzel]

(In reply to comment #4)
> Created an attachment (id=157097)
> patch to fix new not found string problems
> 
> This patch fixes the "new problem" by clearing the statustext value.
> 
> The patch also moves the clearing of the values from on a find bar close to
> just before a find bar open.  With the recent checkin that allows the status to
> be changed on a hidden findbar (w/ ctrl-G), there is a possibility that a
> "wrap" status could be displayed when a findbar is opened with an empty field
> if the last find on a different tab was with ctrl-g and ended on a wrap. (since
> the find bar doesn't open on "wraps" with ctrl-g it can never close, and
> therefore doesn't clear the status values)  It makes more sense to me to clear
> the settings just before the bar opens to ensure that, no matter what, the find
> bar opens with no status indications.
> 
> Finally, since the status is being removed when the find bar opens (or even
> before when it closed), if a previous find string was not found before the
> findbar closed and the findbar is re-opened with ctrl-F, the string will still
> be in the findbar but there will be no "not found status".  This patch puts in
> place an automatic find when the find bar is opened with ctrl-f if the text box
> is not empty to ensure the find status for the displayed string is correct when
> the bar opens.

with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041005
Firefox/0.10, two problems:

1. When Findbar is opened it does not have focus, which it should have.
2. When Findbar is closed after a search (lets assume the string was found) and
reopened, the previous search string is cleared from the Find window but if Find
Next is clicked the search string will be found anew as if it was in the Find
window. It will not be highlighted, though.

(This may not be the right bug number, but it showed up with Bugzilloa search on
Findbar AND clear)

Comment 8

[Raanan Barzel]

Edit Comment #7: "It will not be highlighted" should read "Highlight button will
not highlight it" 

Comment 9

[Blake Ross]

Mike, thanks for the patch! I checked it in, except for the automatic find part.
I don't think it's a problem that the status won't be "not found" just upon
opening the find bar, because I don't think simply hitting Ctrl+F should do the
find. After all, just opening the old find dialog didn't do a find. Since a find
might scroll the patch, I'm uncomfortable doing something that would make the
user lose his position just because he pressed ctrl+f.