Closed Bug 254763 Opened 15 years ago Closed 12 years ago

Odd white border above tab panel in Page Info dialog

Categories

(Firefox :: Tabbed Browser, defect, trivial)

x86
Windows XP
defect
Not set
trivial

Tracking

()

VERIFIED DUPLICATE of bug 265698

People

(Reporter: Tytoba, Unassigned)

References

Details

(Keywords: polish)

Attachments

(3 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040806 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040806 Firefox/0.9.1+

There's an odd border around tab panels in Firefox which doesn't appear in
Windows. See attached screenshot. Left side is taken from Firefox, right side is
an actual XP tab panel with correct borders. I'm using the Silver color for the
default XP theme.

Reproducible: Always
Steps to Reproduce:
Attached image screenshot
WFM with recent builds of 0.9+ branch builds
It works for me with Windows Classic. Under Windows XP style though, I get what
I have in the screenshot using all 3 color schemes (blue, silver, olive). It
does not appear as prominent with blue and olive though. It stands out quite a
bit with silver though, which I use. This
doesn't apply to tabs for tabbed browsing. I see it for regular tabs like the
ones you'll find in the view source window.
i meant view page info in my last comment :) view page source has no tabs.
Attached image 2 more screenshots
I had 2 buddies screen capture Firefox tabs (in this case the page info window)
on different computers. Here's shots of both. Both show the bug, confirming
it's not just me. Both were using Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:1.7) Gecko/20040809 Firefox/0.9.1+.
Flags: blocking-aviary1.0?
This could well be the fault of:
http://lxr.mozilla.org/aviarybranch/source/toolkit/themes/winstripe/global/tabbox.css#30

In Win2K, you get a simple white line here, which is correct as it's the top 3D
edge of the tab panels (and in XP's classic mode). However, in XP (or presumably
other themed enviroments) it's not always correct, and ideally should be handled
by -moz-appearance (urgh).

Putting the following in my userChrome.css removed said line:
    .tabs-left, .tabs-right { border-bottom-width: 0px !important; }
Status: UNCONFIRMED → NEW
Ever confirmed: true
not likely anyone will get to this before 1.0
Flags: blocking-aviary1.0? → blocking-aviary1.0-
You could note also that there shouldn't be a line under the currently selected
tab label, whose background should be continuous with the tabpanel under it.

It is correctly rendered if -moz-appearance is set to none to the <tabs> and the
<tabpanels> (made through DOM-Inspector).

The line is wrongly here with the XP theme presented here on the attached
screenshots, but the problem arises also on Linux with GTK themes.

(On my computer, the height of the <tabs> is also ridiculously small (under
18px), but that's another bug)

_FrnchFrgg_
Sorry for spam, but there is a mistake in previous post : -moz-appearance: none
has to be set on each <tab> child of <tabs>, not on <tabs> itself.
Shouldn't the component of this bug changed from "Tabbed Browser" to "OS
integration" ?
Ignore my last comment, I misunderstood what was "OS integration".
Should I file a new bug about this issue, or is there already one which I cannot
find ?
See http://www.fxfp.com/lib/firefox_usability/, comment #16 for a screenshot of
the wrong separator between tabs and panel.

It really is a usability issue, since the tabs doesn't seem attached to the
panel, and it is far less easy to distinguish between active and inactive tabs.
I think this bug could be resolved as a duplicate of bug 265698, since the odd border is simply a reminiscence of the non native tabbox styling, and the proposed solution of bug 265698 puts a new -moz-appearance on the faulty element, thus resolving this bug.
*** Bug 358506 has been marked as a duplicate of this bug. ***
Keywords: polish
Summary: Odd border above tab panels → Odd white border above tab panel in Page Info dialog
Version: unspecified → Trunk
Assignee: bugs → nobody
Duping to newer bug that has a patch
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 265698
Verified dup
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.